Skip to content

can func_defaults #1990

Merged
merged 2 commits into from Jul 26, 2012

2 participants

@minrk
IPython member
minrk commented Jun 20, 2012

allows passing interactively defined functions as func_defaults

includes test

@minrk
IPython member
minrk commented Jun 20, 2012

Even though I think this is quite minor and is tested, the potential for weirdness in serialization means I would not let this get in 0.13.

@fperez
IPython member
fperez commented Jun 20, 2012

Sounds good, tagged explicitly for 0.14 then.

@minrk
IPython member
minrk commented Jul 21, 2012

This is another one marked for 0.14, but actually done. It's quite simple, so if I get confirmation, I will merge.

@minrk
IPython member
minrk commented Jul 21, 2012

Test results for commit 7cda0b9 (can't merge cleanly)
Platform: darwin

  • python2.6: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 tornado wx wx.aui)
  • python2.7: OK (libraries not available: oct2py wx wx.aui)
  • python3.2: OK (libraries not available: cython matplotlib oct2py pymongo qt rpy2 wx wx.aui)

Not available for testing:

@minrk
IPython member
minrk commented Jul 21, 2012

Since this touches pickleutil, I would rather merge #2069 first, which is more complicated and I would rather rebase this one than that.

minrk added some commits Jun 19, 2012
@minrk minrk can func_defaults
allows passing interactively defined functions as func_defaults
69f00e0
@minrk minrk test canning of func_defaults 939db6e
@minrk
IPython member
minrk commented Jul 26, 2012

Test results for commit 939db6e merged into master
Platform: darwin

  • python2.6: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 tornado wx wx.aui)
  • python2.7: OK (libraries not available: oct2py rpy2 wx wx.aui)
  • python3.2: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 wx wx.aui)

Not available for testing:

@fperez
IPython member
fperez commented Jul 26, 2012

Awesome, nice and clean. Merging now, thanks!

@fperez fperez merged commit 7748dfa into ipython:master Jul 26, 2012
@minrk minrk deleted the minrk:func_defaults branch Mar 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.