frontend test tweaks #1996

Merged
merged 4 commits into from Jun 24, 2012

Conversation

Projects
None yet
3 participants
@minrk
Member

minrk commented Jun 21, 2012

add some encoding to readline history tests that would fail in casting locales (ascii), so that the expected output really matches what should happen.

also relaxes a few timeouts in another test, which were seen to fail while poking around, to avoid spurious failures.

closes #1589

minrk added some commits Jun 21, 2012

relax timeouts in pexpect console-frontend test
avoid false-failures due to slow subprocess startup
match encoding in rlhistory tests
addresses mismatched comparison when locale cannot handle unicode (e.g. ascii)

closes #1589
specify encoding when opening file in test_history
fixes error when running in ASCII locale
@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Jun 21, 2012

Member

Test results for commit 93f5f3d merged into master
Platform: darwin

  • python2.6: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 tornado wx wx.aui)
  • python2.7: OK (libraries not available: oct2py wx wx.aui)
  • python3.2: OK (libraries not available: cython matplotlib oct2py pymongo qt rpy2 wx wx.aui)

Not available for testing: python3.1

Member

minrk commented Jun 21, 2012

Test results for commit 93f5f3d merged into master
Platform: darwin

  • python2.6: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 tornado wx wx.aui)
  • python2.7: OK (libraries not available: oct2py wx wx.aui)
  • python3.2: OK (libraries not available: cython matplotlib oct2py pymongo qt rpy2 wx wx.aui)

Not available for testing: python3.1

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Jun 21, 2012

Member

The above test_pr was run in an ASCII locale on OS X, which revealed another py3-specific test failure due to ascii default encoding.

Member

minrk commented Jun 21, 2012

The above test_pr was run in an ASCII locale on OS X, which revealed another py3-specific test failure due to ascii default encoding.

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jun 21, 2012

Test results for commit 8c11e5c merged into master
Platform: darwin

Not available for testing: python2.6, python3.1

cdeil commented Jun 21, 2012

Test results for commit 8c11e5c merged into master
Platform: darwin

Not available for testing: python2.6, python3.1

@bfroehle

This comment has been minimized.

Show comment
Hide comment
@bfroehle

bfroehle Jun 22, 2012

Contributor

Speaking of frontend tests, I've been seeing this one recently. It's not causing anything to fail, however...

**********************************************************************
IPython test group: IPython.frontend
..............................
----------------------------------------------------------------------
Ran 30 tests in 2.755s

OK
Traceback (most recent call last):
  File "/home/bfroehle/src/ipython/IPython/frontend/qt/console/completion_html.py", line 152, in eventFilter
    if obj == self._text_edit:
AttributeError: 'CompletionHtml' object has no attribute '_text_edit'
Contributor

bfroehle commented Jun 22, 2012

Speaking of frontend tests, I've been seeing this one recently. It's not causing anything to fail, however...

**********************************************************************
IPython test group: IPython.frontend
..............................
----------------------------------------------------------------------
Ran 30 tests in 2.755s

OK
Traceback (most recent call last):
  File "/home/bfroehle/src/ipython/IPython/frontend/qt/console/completion_html.py", line 152, in eventFilter
    if obj == self._text_edit:
AttributeError: 'CompletionHtml' object has no attribute '_text_edit'
@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Jun 22, 2012

Member

interesting - I've never seen that error, and from the code, it makes no sense at all for it to happen - the event filter is registered after the attribute is assigned. It could be a garbage collection issue on exit, where the event filter is still registered, but the object has started to be deleted.

Member

minrk commented Jun 22, 2012

interesting - I've never seen that error, and from the code, it makes no sense at all for it to happen - the event filter is registered after the attribute is assigned. It could be a garbage collection issue on exit, where the event filter is still registered, but the object has started to be deleted.

@bfroehle

This comment has been minimized.

Show comment
Hide comment
@bfroehle

bfroehle Jun 22, 2012

Contributor

The garbage collection hypothesis seems pretty reasonable, given that the
error prints after the test group has finished.

Contributor

bfroehle commented Jun 22, 2012

The garbage collection hypothesis seems pretty reasonable, given that the
error prints after the test group has finished.

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Jun 22, 2012

Member

I wrote, but apparently failed to post, a note about @cdeil's test_pr run: I believe all failures listed are due to libedit, and should not be considered real failures (libedit is fully expected to break all kinds of stuff). I can confirm that an ASCII locale no longer fails (I could reproduce exactly the failures reported in #1589, and they are fixed).

Getting virtualenv to install the right readline is a bit of a pain, and I don't quite remember how to do it.

Member

minrk commented Jun 22, 2012

I wrote, but apparently failed to post, a note about @cdeil's test_pr run: I believe all failures listed are due to libedit, and should not be considered real failures (libedit is fully expected to break all kinds of stuff). I can confirm that an ASCII locale no longer fails (I could reproduce exactly the failures reported in #1589, and they are fixed).

Getting virtualenv to install the right readline is a bit of a pain, and I don't quite remember how to do it.

minrk added a commit that referenced this pull request Jun 24, 2012

Merge pull request #1996 from minrk/ascii
frontend test tweaks for ASCII locale

add some encoding to readline history tests that would fail in casting locales (ascii), so that the expected output really matches what should happen.

also relaxes a few timeouts in another test, which were seen to fail while poking around, to avoid spurious failures.

closes #1589

@minrk minrk merged commit 3c2ce20 into ipython:master Jun 24, 2012

@minrk minrk deleted the minrk:ascii branch Mar 31, 2014

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #1996 from minrk/ascii
frontend test tweaks for ASCII locale

add some encoding to readline history tests that would fail in casting locales (ascii), so that the expected output really matches what should happen.

also relaxes a few timeouts in another test, which were seen to fail while poking around, to avoid spurious failures.

closes #1589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment