Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove umlauts so py3 installations on LANG=C systems succeed. #2063

Merged
merged 1 commit into from Jul 1, 2012

Conversation

Projects
None yet
3 participants
Owner

fperez commented Jun 30, 2012

Closes #2057.

Owner

fperez commented Jun 30, 2012

@jstenar, are you OK with this? BTW, I also don't use Pérez (my real spelling) but instead use Perez to avoid these kinds of issues. I prefer IPython to be installable than to deal with these bizarre corner cases, but since it does modify how we spell your name in the release.py file, I'd like your OK before we merge it.

Owner

minrk commented Jun 30, 2012

Sorry about this - does it mean we need to pull 0.13 (or push 0.13.1 immediately)? If it's not even installable on ascii locales, that's pretty harsh.

Owner

fperez commented Jun 30, 2012

See discussion in #2057: I thought the same at first, but it seems that these days, LANG=C is much less common than it used to be, as most *nix platforms do set a UTF-8 locale...

What do you think?

Member

jstenar commented Jul 1, 2012

I'm fine with this so I'll go ahead and merge.

@jstenar jstenar added a commit that referenced this pull request Jul 1, 2012

@jstenar jstenar Merge pull request #2063 from fperez/lang_c_py3
Remove umlauts so py3 installations on LANG=C systems succeed.
9964f66

@jstenar jstenar merged commit 9964f66 into ipython:master Jul 1, 2012

Owner

fperez commented Jul 1, 2012

On Sat, Jun 30, 2012 at 11:58 PM, Jörgen Stenarson
reply@reply.github.com
wrote:

I'm fine with this so I'll go ahead and merge.

By all means!

@minrk minrk added a commit that referenced this pull request Jul 21, 2012

@minrk minrk Backport PR #2063: Remove umlauts so py3 installations on LANG=C syst…
…ems succeed.


Closes #2057.
4218f42

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

@jstenar jstenar Merge pull request #2063 from fperez/lang_c_py3
Remove umlauts so py3 installations on LANG=C systems succeed.
804251b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment