record sysinfo in sdist #2068

Merged
merged 1 commit into from Jun 30, 2012

Conversation

Projects
None yet
2 participants
@minrk
Member

minrk commented Jun 30, 2012

closes #2054

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Jun 30, 2012

Member

Wow, you're becoming quite the distutils expert. Be careful, you might like it ;)

Thanks, looks solid; merging now.

Member

fperez commented Jun 30, 2012

Wow, you're becoming quite the distutils expert. Be careful, you might like it ;)

Thanks, looks solid; merging now.

fperez added a commit that referenced this pull request Jun 30, 2012

Merge pull request #2068 from minrk/sysinfo
record sysinfo in sdist

closes #2054

@fperez fperez merged commit b2ab7f5 into ipython:master Jun 30, 2012

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Jul 1, 2012

Member

Here's how I do ~100% of my distutils customization (here, and in pyzmq where it's much more complicated):

  1. Stick import IPython; IPython.embed() in the run() method.
  2. Inspect with self.method??
  3. Repeat 2. until I get to the part that needs to behave differently
  4. Wonder why it doesn't work the way it seems like it should

Be careful, you might like it ;)

I don't think there's any risk of that.

Member

minrk commented Jul 1, 2012

Here's how I do ~100% of my distutils customization (here, and in pyzmq where it's much more complicated):

  1. Stick import IPython; IPython.embed() in the run() method.
  2. Inspect with self.method??
  3. Repeat 2. until I get to the part that needs to behave differently
  4. Wonder why it doesn't work the way it seems like it should

Be careful, you might like it ;)

I don't think there's any risk of that.

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Jul 1, 2012

Member

On Sat, Jun 30, 2012 at 6:42 PM, Min RK
reply@reply.github.com
wrote:

I don't think there's any risk of that.

I know, you have a sense of taste :)

Member

fperez commented Jul 1, 2012

On Sat, Jun 30, 2012 at 6:42 PM, Min RK
reply@reply.github.com
wrote:

I don't think there's any risk of that.

I know, you have a sense of taste :)

Carreau added a commit to Carreau/ipython that referenced this pull request Jul 13, 2012

record sysinfo in sdist
closes #2054

backported to 0.13.1 from PR #2068

minrk added a commit that referenced this pull request Jul 21, 2012

@minrk minrk deleted the minrk:sysinfo branch Mar 31, 2014

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2068 from minrk/sysinfo
record sysinfo in sdist

closes #2054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment