re-aliad %ed to %edit in qtconsole #2086

Merged
merged 1 commit into from Jul 10, 2012

Conversation

Projects
None yet
2 participants
Owner

Carreau commented Jul 3, 2012

fixes #2085

should be backported to 0.13.1

Owner

fperez commented Jul 5, 2012

But it should be done using the new %alias_magic facility, not by writing a new standalone function. Since we really don't want this commit at all, once you have a version with alias_magic, just rebase removing the commit above and force push, so we only keep the clean solution in the history.

Owner

Carreau commented Jul 5, 2012

done.

Owner

fperez commented Jul 5, 2012

let's start instead using the line/cell specific calls that provide a slightly more robust api (no need to parse anything):

self.run_line_magic('alias_magic', 'ed edit')

again, just nuke and force push since it's just a fix.

Then we can merge, thanks!

Owner

Carreau commented Jul 10, 2012

Done, sorry for the delay I was away for a few days.

Owner

fperez commented Jul 10, 2012

No worries! Thanks, merging now.

@fperez fperez added a commit that referenced this pull request Jul 10, 2012

@fperez fperez Merge pull request #2086 from Carreau/fixes-2085
re-alias %ed to %edit in qtconsole with new alias_magic api.
bf4aa6d

@fperez fperez merged commit bf4aa6d into ipython:master Jul 10, 2012

@Carreau Carreau added a commit to Carreau/ipython that referenced this pull request Jul 13, 2012

@Carreau Carreau re-aliad %ed to %edit in qtconsole
fixes #2085

backported to 0.13.1 from PR #2086
765bae8

@minrk minrk added a commit that referenced this pull request Jul 21, 2012

@minrk minrk Backport PR #2086: re-aliad %ed to %edit in qtconsole
fixes #2085

should be backported to 0.13.1
1c1222f

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

@fperez fperez Merge pull request #2086 from Carreau/fixes-2085
re-alias %ed to %edit in qtconsole with new alias_magic api.
97f9e9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment