Fix (some) Python 3.2 ResourceWarnings #2088

Merged
merged 3 commits into from Jul 4, 2012

Conversation

Projects
None yet
2 participants
Contributor

bfroehle commented Jul 3, 2012

To fix the test errors in gh-2083, it was necessary to replace one instance of
exec compile(open(..., 'rb').read(), ...) in ... with

with open(..., 'rb') as f:
    exec compile(f.read(), ...) in ...

In addition I've tackled several other resource warnings that come from running iptest with PYTHONWARNINGS="d".

Owner

takluyver commented Jul 4, 2012

This looks sensible. Running the tests now.

Owner

takluyver commented Jul 4, 2012

Test results for commit d8ad687 merged into master
Platform: linux2

  • python2.7: OK (libraries not available: oct2py rpy2)
  • python3.1: Failed, log at https://gist.github.com/3049653 (libraries not available: cython matplotlib numpy oct2py pymongo qt rpy2 wx wx.aui zmq)
  • python3.2: OK (libraries not available: cython oct2py pymongo rpy2 wx wx.aui)

Not available for testing: python2.6

takluyver added a commit that referenced this pull request Jul 4, 2012

Merge pull request #2088 from bfroehle/_2083_py32_test_failures
Fix (some) Python 3.2 ResourceWarnings

@takluyver takluyver merged commit d6009ff into ipython:master Jul 4, 2012

Owner

takluyver commented Jul 4, 2012

And merged. Thanks, @bfroehle .

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2088 from bfroehle/_2083_py32_test_failures
Fix (some) Python 3.2 ResourceWarnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment