fix completer deletting newline #2101

Merged
merged 1 commit into from Jul 5, 2012

Conversation

Projects
None yet
3 participants
@Carreau
Owner

Carreau commented Jul 5, 2012

should fixes #2082

do not forget to backport to 0.13.1

@Carreau Carreau referenced this pull request Jul 5, 2012

Closed

Qt Console output spacing #2082

@Carreau

This comment has been minimized.

Show comment Hide comment
@Carreau

Carreau Jul 5, 2012

Owner

Note : force-push to change author.

Owner

Carreau commented Jul 5, 2012

Note : force-push to change author.

@bfroehle

This comment has been minimized.

Show comment Hide comment
@bfroehle

bfroehle Jul 5, 2012

Contributor

This does resolve the issue I was having in #2082.

Contributor

bfroehle commented Jul 5, 2012

This does resolve the issue I was having in #2082.

@fperez

This comment has been minimized.

Show comment Hide comment
@fperez

fperez Jul 5, 2012

Owner

Yup, fixes here too, thanks!

Owner

fperez commented Jul 5, 2012

Yup, fixes here too, thanks!

@fperez

This comment has been minimized.

Show comment Hide comment
@fperez

fperez Jul 5, 2012

Owner

I'm not the most experienced with Qt but the logic looks simple enough, and with the confirmation that it fixes the problem indeed, let's go ahead and merge this. Great work, thanks for the quick turnaround!

Owner

fperez commented Jul 5, 2012

I'm not the most experienced with Qt but the logic looks simple enough, and with the confirmation that it fixes the problem indeed, let's go ahead and merge this. Great work, thanks for the quick turnaround!

fperez added a commit that referenced this pull request Jul 5, 2012

Merge pull request #2101 from Carreau/fixes-2082
Fix completer deleting newline in qtconsole.

Fixes #2082.

@fperez fperez merged commit 811283a into ipython:master Jul 5, 2012

Carreau added a commit to Carreau/ipython that referenced this pull request Jul 13, 2012

fix completer deletting newline
fixes #2082

backported to 0.13.1 from PR #2101

minrk added a commit that referenced this pull request Jul 21, 2012

Backport PR #2101: fix completer deletting newline
should fixes #2082

do not forget to backport to 0.13.1

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2101 from Carreau/fixes-2082
Fix completer deleting newline in qtconsole.

Fixes #2082.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment