Skip to content

Fix logging on interactive shell. #2102

Merged
merged 1 commit into from Jul 5, 2012

2 participants

@RuiPereira

Add a missing string format code in init_logs() and move init_logstart() after init_magics(), to fix dependency issues.

This is a proposed fix for the case a log file is given in ipython_config.py, eg:

# Start logging to the given file in append mode.                                                                                         
import os
from time import strftime
f = os.path.join(c.TerminalIPythonApp.ipython_dir, strftime('%Y-%m-%d')+".py")
c.TerminalInteractiveShell.logappend = f

which completely breaks in current master code

@RuiPereira RuiPereira Fix logging on interactive shell.
Add a missing string format code in init_logs() and move init_logstart() after init_magics(), to fix dependency issues.
b1a64c8
@fperez
IPython member
fperez commented Jul 5, 2012

Yup, looks good; thanks!

@fperez fperez merged commit 56d2be5 into ipython:master Jul 5, 2012
@fperez fperez referenced this pull request Jul 5, 2012
Closed

error when starting ipython #2087

@Carreau Carreau added a commit to Carreau/ipython that referenced this pull request Jul 13, 2012
@RuiPereira RuiPereira Fix logging on interactive shell.
Add a missing string format code in init_logs() and move init_logstart() after init_magics(), to fix dependency issues.

backported to 0.13.1 from PR #2102
52b881c
@minrk minrk added a commit that referenced this pull request Jul 21, 2012
@minrk minrk Backport PR #2102: Fix logging on interactive shell.
Add a missing string format code in init_logs() and move init_logstart() after init_magics(), to fix dependency issues.

This is a proposed fix for the case a log file is given in `ipython_config.py`, eg:

```python
# Start logging to the given file in append mode.
import os
from time import strftime
f = os.path.join(c.TerminalIPythonApp.ipython_dir, strftime('%Y-%m-%d')+".py")
c.TerminalInteractiveShell.logappend = f
```

which completely breaks in current `master` code
a4d7268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.