Skip to content

Fix tab completion with IPython.embed_kernel(). #2170

Merged
merged 1 commit into from Jul 20, 2012

2 participants

@bfroehle

Closes #2162.

@bfroehle bfroehle commented on the diff Jul 19, 2012
IPython/core/interactiveshell.py
@@ -1809,7 +1809,6 @@ def init_readline(self):
self.readline_no_record = no_op_context
self.set_readline_completer = no_op
self.set_custom_completer = no_op
- self.set_completer_frame = no_op
@bfroehle
bfroehle added a note Jul 19, 2012

This was unceremoniously added in 745e9cb without much explanation.

I don't think that we need this to be a no-op, as the completer framework should be in place regardless of whether or not it gets used.

@fperez
IPython member
fperez added a note Jul 20, 2012

The thing is: this was meant to fix problems when in the terminal, readline wasn't available for some reason. We didn't have the notion of 'kernel completions' back then.

Now that such a thing exists, obviously we need the completion machinery to function even when there is no tty attached.

@bfroehle
bfroehle added a note Jul 20, 2012

Aha, thanks for the history! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@bfroehle

Test results for commit 58532e9 merged into master
Platform: linux2

  • python2.6: OK (libraries not available: matplotlib oct2py pymongo qt rpy2 wx wx.aui)
  • python2.7: OK
  • python3.2: OK (libraries not available: oct2py pymongo rpy2 wx wx.aui)

Not available for testing:

@fperez fperez merged commit 2933cdd into ipython:master Jul 20, 2012
@yarikoptic yarikoptic added a commit to yarikoptic/ipython that referenced this pull request May 2, 2014
@yarikoptic yarikoptic Merge commit 'rel-0.13-33-gcfc5692' into debian-01X
* commit 'rel-0.13-33-gcfc5692': (33 commits)
  Backport PR #2347: adjust division error message checking to account for Python 3
  Backport PR #2305: RemoteError._render_traceback_ calls self.render_traceback
  Backport PR #2280: fix SSH passwordless check for OpenSSH
  Backport PR #2270: SSHLauncher tweaks
  Backport PR #2261: Fix: longest_substr([]) -> ''
  Backport PR #2250: fix html in notebook example
  Backport PR #2235: remove spurious print statement from setupbase.py
  fixup
  Backport PR #2223: Custom tracebacks
  Backport PR #2214: use KernelApp.exec_lines/files in IPEngineApp
  Backport PR #2212: catch errors in markdown javascript
  Backport PR #2194: clean nan/inf in json_clean
  Backport PR #2177: remove numpy install from travis/tox scripts
  Backport PR #2169: ipdb: pdef, pdoc, pinfo magics all broken
  Backport PR #2186: removed references to h5py dependence in octave magic documentation
  Backport PR #2185: added test for %store, fixed storemagic
  Backport PR #2170: Fix tab completion with IPython.embed_kernel().
  Backport PR #2163: fix 'remote_profie_dir' typo in SSH launchers
  Backport PR #2117: use explicit url in notebook example
  Backport PR #2126: ipcluster broken with any batch (PBS/LSF/SGE)
  ...
fc7c7f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.