use KernelApp.exec_lines/files in IPEngineApp #2214

Merged
merged 1 commit into from Jul 29, 2012

Projects

None yet

2 participants

@minrk
Member
minrk commented Jul 27, 2012

This change means that all your startup/exec_lines config is inherited by engines.

should be backported for 0.13.1, because engine startup code is impossible to configure in 0.13.

The real long-term fix for this is to make IPEngineApp a subclass of IPKernelApp, but this should be an adequate band-aid until then.

closes #2213

@minrk minrk use KernelApp.exec_lines/files in IPEngineApp
should be backported to 0.13.1, because engine startup code was impossible to configure.
14f71f0
@ellisonbg
Member

I am fine with this as a temporary solution. The code looks good.

@minrk
Member
minrk commented Jul 28, 2012

Test results for commit 14f71f0 merged into master
Platform: darwin

  • python2.6: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 tornado wx wx.aui)
  • python2.7: OK (libraries not available: oct2py rpy2 wx wx.aui)
  • python3.2: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 wx wx.aui)

Not available for testing:

@minrk minrk merged commit 2ff8a90 into ipython:master Jul 29, 2012
@minrk minrk added a commit that referenced this pull request Jul 29, 2012
@minrk minrk Backport PR #2214: use KernelApp.exec_lines/files in IPEngineApp
This change means that all your startup/exec_lines config is inherited by engines.

should be backported for 0.13.1, because engine startup code is impossible to configure in 0.13.

The real long-term fix for this is to make IPEngineApp a subclass of IPKernelApp, but this should be an adequate band-aid until then.

closes #2213
b1241d5
@minrk minrk deleted the minrk:engine_startup branch Mar 31, 2014
@yarikoptic yarikoptic added a commit to yarikoptic/ipython that referenced this pull request May 2, 2014
@yarikoptic yarikoptic Merge commit 'rel-0.13-33-gcfc5692' into debian-01X
* commit 'rel-0.13-33-gcfc5692': (33 commits)
  Backport PR #2347: adjust division error message checking to account for Python 3
  Backport PR #2305: RemoteError._render_traceback_ calls self.render_traceback
  Backport PR #2280: fix SSH passwordless check for OpenSSH
  Backport PR #2270: SSHLauncher tweaks
  Backport PR #2261: Fix: longest_substr([]) -> ''
  Backport PR #2250: fix html in notebook example
  Backport PR #2235: remove spurious print statement from setupbase.py
  fixup
  Backport PR #2223: Custom tracebacks
  Backport PR #2214: use KernelApp.exec_lines/files in IPEngineApp
  Backport PR #2212: catch errors in markdown javascript
  Backport PR #2194: clean nan/inf in json_clean
  Backport PR #2177: remove numpy install from travis/tox scripts
  Backport PR #2169: ipdb: pdef, pdoc, pinfo magics all broken
  Backport PR #2186: removed references to h5py dependence in octave magic documentation
  Backport PR #2185: added test for %store, fixed storemagic
  Backport PR #2170: Fix tab completion with IPython.embed_kernel().
  Backport PR #2163: fix 'remote_profie_dir' typo in SSH launchers
  Backport PR #2117: use explicit url in notebook example
  Backport PR #2126: ipcluster broken with any batch (PBS/LSF/SGE)
  ...
fc7c7f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment