Fix regression in embed() from pull-request #2096. #2245

Merged
merged 1 commit into from Aug 4, 2012

4 participants

@bfroehle

With certain sets of arguments compile_flags might be left as None. This caused IPython to internally raise a TypeError when it tried to do a bitwise or between shell.compile.flags and PyCF_ONLY_AST in CachingCompiler.ast_parse.

The regression was introduced in:
b70ac12 embed(): Default to the future compile flags of the calling frame.

Closes #2243.

@bfroehle bfroehle Fix regression in embed() from pull-request #2096.
With certain sets of arguments `compile_flags` might be left as `None`. This
caused IPython to internally raise a TypeError when it tried to do a
bitwise or between `shell.compile.flags` and `PyCF_ONLY_AST` in
`CachingCompiler.ast_parse`.

The regression was introduced in:
  b70ac12 embed(): Default to the future compile flags of the calling frame.
89b4dd7
@fperez
IPython member

@certik, could you check that this fixes completely your use case? Thanks a ton @bfroehle for the quick turnaround!

@certik

I am on it.

@certik

Yes, this fixes it for me. Thanks @bfroehle, I really appreciate such a quick fix!

@Carreau
IPython member

Merging if it works.

@Carreau Carreau merged commit c90b6b0 into ipython:master Aug 4, 2012
@certik

I just checked again the master of ipython and it works great after the merge.

Thanks for the quick fix!

@Carreau
IPython member

Happy to have people following github devs has other watch facebook :-)

@fperez
IPython member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment