Skip to content

fix html in notebook example #2250

Merged
merged 1 commit into from Aug 4, 2012

3 participants

@Carreau
IPython member
Carreau commented Aug 4, 2012

please backport to 0.13.1

@Carreau Carreau fix no closing iframe tag
was preventing the display of the static version converted with
nbconvert
43a7072
@Carreau
IPython member
Carreau commented Aug 4, 2012

basically when converted to static with nbconvert everything after the iframe was not renderd.

@takluyver
IPython member

Do iframe tags work if you just end the tag with />?

@Carreau
IPython member
Carreau commented Aug 4, 2012

as some content will be injected between opening and closing tag, I wouldn't bet on the ability of the browser to create the closing tag ... and it is not in the spec to allow for <iframe/>

@takluyver
IPython member
@Carreau
IPython member
Carreau commented Aug 4, 2012

you can look at the difference here :
this commit
master constantly up to date

@bfroehle
bfroehle commented Aug 4, 2012

@takluyver No, iframe is not a void element and therefore must have a closing tag.

Good catch. Merging now.

@bfroehle bfroehle merged commit 079f8ed into ipython:master Aug 4, 2012
@minrk minrk added a commit that referenced this pull request Aug 4, 2012
@minrk minrk Backport PR #2250: fix html in notebook example
please backport to 0.13.1
0131ecc
@minrk minrk added a commit that referenced this pull request Sep 1, 2012
@minrk minrk Backport PR #2250: fix html in notebook example
please backport to 0.13.1
8f3a62b
@yarikoptic yarikoptic added a commit to yarikoptic/ipython that referenced this pull request May 2, 2014
@yarikoptic yarikoptic Merge commit 'rel-0.13-33-gcfc5692' into debian-01X
* commit 'rel-0.13-33-gcfc5692': (33 commits)
  Backport PR #2347: adjust division error message checking to account for Python 3
  Backport PR #2305: RemoteError._render_traceback_ calls self.render_traceback
  Backport PR #2280: fix SSH passwordless check for OpenSSH
  Backport PR #2270: SSHLauncher tweaks
  Backport PR #2261: Fix: longest_substr([]) -> ''
  Backport PR #2250: fix html in notebook example
  Backport PR #2235: remove spurious print statement from setupbase.py
  fixup
  Backport PR #2223: Custom tracebacks
  Backport PR #2214: use KernelApp.exec_lines/files in IPEngineApp
  Backport PR #2212: catch errors in markdown javascript
  Backport PR #2194: clean nan/inf in json_clean
  Backport PR #2177: remove numpy install from travis/tox scripts
  Backport PR #2169: ipdb: pdef, pdoc, pinfo magics all broken
  Backport PR #2186: removed references to h5py dependence in octave magic documentation
  Backport PR #2185: added test for %store, fixed storemagic
  Backport PR #2170: Fix tab completion with IPython.embed_kernel().
  Backport PR #2163: fix 'remote_profie_dir' typo in SSH launchers
  Backport PR #2117: use explicit url in notebook example
  Backport PR #2126: ipcluster broken with any batch (PBS/LSF/SGE)
  ...
fc7c7f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.