Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

add missing location when disambiguating controller IP #2269

Merged
merged 1 commit into from Aug 9, 2012

Conversation

Projects
None yet
2 participants
Owner

minrk commented Aug 8, 2012

prevented ip=* from resolving correctly engine-side (would always give loopback)

This bug was introduced in the connection cleanup after 0.13, so does not need backporting.

add missing location when disambiguating controller IP
prevented ip=* from resolving correctly engine-side

This bug was introduced in the connection cleanup after 0.13,
so does not need backporting.

@minrk minrk referenced this pull request Aug 8, 2012

Merged

SSHLauncher tweaks #2270

Owner

fperez commented Aug 9, 2012

Straightforward enough, and since we've had confirmation in the discussion on-list that it does help, we can go ahead. Merging now, thanks!

fperez added a commit that referenced this pull request Aug 9, 2012

Merge pull request #2269 from minrk/disambiguate_ip
add missing location when disambiguating controller IP.

Fixes a recently introduced bug that prevented ip=* from resolving correctly engine-side (would always give loopback).

@fperez fperez merged commit fb439f4 into ipython:master Aug 9, 2012

minrk added a commit that referenced this pull request Aug 9, 2012

Backport PR #2270: SSHLauncher tweaks
* use pipes.quote on SSH commands
* default SSHEngineSetLauncher to `ipengine` instead of import-based command.

This is actually the intended behavior, and only brings EngineSet inline with SSHEngine and SSHController, which both use the simplified command.

* Should be backported to 0.13.1
* Must be not be merged before #2269

minrk added a commit that referenced this pull request Sep 1, 2012

Backport PR #2270: SSHLauncher tweaks
* use pipes.quote on SSH commands
* default SSHEngineSetLauncher to `ipengine` instead of import-based command.

This is actually the intended behavior, and only brings EngineSet inline with SSHEngine and SSHController, which both use the simplified command.

* Should be backported to 0.13.1
* Must be not be merged before #2269

@minrk minrk deleted the minrk:disambiguate_ip branch Mar 31, 2014

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2269 from minrk/disambiguate_ip
add missing location when disambiguating controller IP.

Fixes a recently introduced bug that prevented ip=* from resolving correctly engine-side (would always give loopback).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment