Skip to content

Remove old plugin system #2291

Merged
merged 2 commits into from Oct 2, 2012

5 participants

@ellisonbg
IPython member

When we refatored the core, I added a plugin system. It has turned out that it was not really used because it really is nearly identical to the extension idea. It even horribly confusing (huh, what's the diff between the two?). I have completely removed the plugin system.

ellisonbg added some commits Aug 10, 2012
@ellisonbg ellisonbg Removing plugin module and its tests.
When we refactored the core we created a plugin system, but we
don't use it for anything and it is completely redundant (we
already have extensions).
e67c30a
@ellisonbg ellisonbg Cleaning up extensions that used plugins. 1e6eb00
@fperez
IPython member
fperez commented Aug 11, 2012

Yes, and I think that with the refactored magics that can cleanly hold isolated state, the last bit of justification for these is gone. The code looks clean, let me run test_pr for sanity.

I think we should give it a day or two for others to pitch in, in case someone really disagrees.

The only comment I'd make is that now is the time to add a note to the docs, in the what's new document, backwards-incompatible changes, mentioning this big removal. Otherwise we'll forget later.

@fperez
IPython member
fperez commented Aug 11, 2012

Test results for commit 1e6eb00 merged into master (d3f6cea)
Platform: linux2

  • python2.7: OK (libraries not available: azure)
  • python3.2: OK (libraries not available: azure cython matplotlib oct2py pygments pymongo rpy2 wx wx.aui)

Not available for testing: python2.6

@minrk
IPython member
minrk commented Aug 11, 2012

Makes sense to me. Ping the list, in case anyone ever actually wrote a plugin?

@fperez
IPython member
@takluyver
IPython member
@ellisonbg
IPython member
@takluyver
IPython member

Did the list get pinged about this? I don't see anything with 'plugin' in the subject in the archives for August.

@Carreau
IPython member
Carreau commented Sep 28, 2012

LIst has still not been pingged I think. I would prefere SO which speek better english than me, and who knows the pluggin system a little more to ping the list, but I can do it.
Let me know.

@takluyver
IPython member

I have now pinged both lists. For reference, here's the message: http://mail.scipy.org/pipermail/ipython-user/2012-September/011255.html

So far (3 days), no-one has objected.

@ellisonbg
IPython member

Thanks for pinging the lists, I don't think there is any objections so I am going to merge.

@ellisonbg ellisonbg merged commit 2e9bf5c into ipython:master Oct 2, 2012
@cdeil cdeil referenced this pull request in catherinedevlin/ipython-sql Apr 2, 2013
Closed

ImportError: No module named plugin #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.