Notebook: Store the username in a cookie whose name is unique. #2352

Merged
merged 1 commit into from Aug 31, 2012

Conversation

Projects
None yet
4 participants
Contributor

bfroehle commented Aug 28, 2012

Cookies cannot be saved on a per-port basis, so a cookie "username" is shared
across all running IPython notebooks with the same hostname. Using a unique
cookie name prevents this collision.

This allows a user to start multiple IPython notebooks and be logged into
each.

Closes #1459 & #2351.

Notebook: Store the username in a cookie whose name is unique.
Cookies cannot be saved on a per-port basis, so a cookie "username" is
shared across all running IPython notebooks with the same hostname.
Using a unique cookie name prevents this collision.

This allows a user to start multiple IPython notebooks and be logged into
each.

This pull request passes (merged 5aca05c into 011222a).

Contributor

bfroehle commented Aug 28, 2012

Test results for commit 5aca05c merged into master (011222a)
Platform: linux2

  • python2.7: OK (libraries not available: azure)
  • python3.2: OK (libraries not available: azure cython oct2py pymongo rpy2 wx wx.aui)

Extra args: ['--all']
Not available for testing: python2.6

Owner

minrk commented Aug 30, 2012

looks simple and sensible to me.

Owner

Carreau commented Aug 31, 2012

Works great !
Merging !

Carreau added a commit that referenced this pull request Aug 31, 2012

Merge pull request #2352 from bfroehle/notebook_unique_cookie_name
Notebook: Store the username in a cookie whose name is unique.

Cookies cannot be saved on a per-port basis, so a cookie "username" is shared
across all running IPython notebooks with the same hostname. Using a unique
cookie name prevents this collision.

This allows a user to start multiple IPython notebooks and be logged into
each.

@Carreau Carreau merged commit 57ed016 into ipython:master Aug 31, 2012

1 check passed

default The Travis build passed
Details

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2352 from bfroehle/notebook_unique_cookie_name
Notebook: Store the username in a cookie whose name is unique.

Cookies cannot be saved on a per-port basis, so a cookie "username" is shared
across all running IPython notebooks with the same hostname. Using a unique
cookie name prevents this collision.

This allows a user to start multiple IPython notebooks and be logged into
each.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment