Skip to content

IndentationError display #2399

Merged
merged 2 commits into from Sep 13, 2012

3 participants

@takluyver
IPython member

IndentationError is a subclass of SyntaxError, and they should display in a similar fashion, with the problematic line and line number shown. We were being over-specific with our type checking.

Closes #2398.

@Carreau
IPython member
Carreau commented Sep 11, 2012

Looks ok for me.
Waiting for one more pair of eyes before merging just in case.

@takluyver
IPython member

Thanks @Carreau . I may merge it tomorrow evening, as I see we're building up pull requests again. But if you'd rather hold it for someone else to look at, let me know.

@Carreau
IPython member
Carreau commented Sep 13, 2012

Merging.

@Carreau Carreau merged commit 6ad4114 into ipython:master Sep 13, 2012

1 check passed

Details default The Travis build passed
@pleabargain

I'm sorry. I can't tell what v. of Ipython this was implemented.
.12? 13? 13.1?

I ask because lines numbers in the code cells are not showing up in notebooks .13

thank you
Dennis

@takluyver
IPython member

It looks like it didn't go into 0.13.1, so you won't see the fix until 0.14.

@pleabargain

Ok. Thanks! Is dev .14 ready for new users or should I stick with .13 in your opinion?

@takluyver
IPython member

Unless something like this is a major problem, we'd generally encourage users to stick with the released version, i.e. 0.13.1. But we do try to avoid breaking the development version, to allow a sort of continuous beta-testing.

@minrk minrk added a commit that referenced this pull request Mar 5, 2013
@minrk minrk Backport PR #2399: IndentationError display
IndentationError is a subclass of SyntaxError, and they should display in a similar fashion, with the problematic line and line number shown. We were being over-specific with our type checking.

Closes #2398.
df79d72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.