WIP: Transform linenumber #2402

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@jasongrout
Member

This pull request makes it possible to modify the transforms applied and also modifies the transformation code to pass the line numbers.

This isn't ready to be merged (I'm sure there are other places in the code that would need to be changed), but it does illustrate the sorts of changes that would be great for the Sage customizations.

See also http://mail.scipy.org/pipermail/ipython-dev/2012-September/010239.html

(WIP stands for Work in Progress...)

Jason Grout added some commits Sep 11, 2012
Jason Grout Move transforms to be an attribute of the class so they can be modifi…
…ed by extensions.
c3153a9
Jason Grout Fix typo 988c012
Jason Grout Make transformations take the line number as well as the line string.
For backwards compatibility, we could also inspect the function to see if it takes 2 arguments, and if not, just pass in the line string.
64e38e5
@takluyver
Member

Thanks - I'm not sure line number is quite the right way to do this, but I do have some kind of stateful transformers in mind. And I agree that we need to move the list of transformations out where it can be accessed.

(This falls under the heading of #2293, aka IPEP 2)

@takluyver
Member

@jasongrout I'm going to close this one in favour of #2447 - I'm trying to bring our PR count down a bit. Do keep an eye on that one.

@takluyver takluyver closed this Oct 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment