Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix input splitter so that lines after decorators are properly transformed #2428

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Owner

jasongrout commented Sep 25, 2012

Before this commit, the "def" line below would not be transformed:

@interact
def f(n=1):
    print n

See http://mail.scipy.org/pipermail/ipython-dev/2012-September/010329.html

Jason Grout Fix input splitter so that lines after decorators are properly transf…
…ormed

Before this commit, the "def" line below would not be transformed:

@interact
def f(n=1):
    print n

See http://mail.scipy.org/pipermail/ipython-dev/2012-September/010329.html
4bf74d7
Owner

takluyver commented Sep 25, 2012

(Travis failure is a problem with Travis, not this code)

Is there a simple way to add a test for this?

Owner

jasongrout commented Sep 25, 2012

I guess we could add a transformer that printed out what it was supposed to transform, then run the code and check the output.

Owner

takluyver commented Sep 25, 2012

The printing step probably isn't needed - the transformer can just add the
input it gets to a list which the test examines.

@minrk minrk closed this Oct 21, 2012

Owner

jasongrout commented Nov 29, 2012

Did we decide to reject this pull request?

Owner

takluyver commented Nov 29, 2012

Can you make an issue for the problem, so that we don't forget about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment