Add deprecation warnings for sympyprinting #2480

Merged
merged 1 commit into from Oct 14, 2012

Conversation

Projects
None yet
4 participants
@flacjacket
Contributor

flacjacket commented Oct 11, 2012

The sympyprinting extension has been moved to SymPy for the upcoming 0.7.2 release (see sympy/sympy#1559). For versions containing the new extension, print a deprecation warning and load the extension from SymPy.

@asmeurer

This comment has been minimized.

Show comment Hide comment
@asmeurer

asmeurer Oct 12, 2012

Contributor

I would also add a big comment to the top of the file the same effect, so that if anyone ever comes along trying to fix a bug in the extension, they will know that they really should be looking at the SymPy code.

Contributor

asmeurer commented Oct 12, 2012

I would also add a big comment to the top of the file the same effect, so that if anyone ever comes along trying to fix a bug in the extension, they will know that they really should be looking at the SymPy code.

+ pass
+ else:
+ warnings.warn("The sympyprinting extension in IPython is deprecated, "
+ "use sympy.interactive.ipythonprinting")

This comment has been minimized.

Show comment Hide comment
@asmeurer

asmeurer Oct 12, 2012

Contributor

Should DeprecationWarning be used? This is a question for the IPython guys. DeprecationWarning is the correct warning, but due to a Python core design decision, it is not shown by default, so that almost no one would actually see it. What is your policy on this?

@asmeurer

asmeurer Oct 12, 2012

Contributor

Should DeprecationWarning be used? This is a question for the IPython guys. DeprecationWarning is the correct warning, but due to a Python core design decision, it is not shown by default, so that almost no one would actually see it. What is your policy on this?

This comment has been minimized.

Show comment Hide comment
@takluyver

takluyver Oct 12, 2012

Owner

I'd say we shouldn't use DeprecationWarning for that reason. The idea is that developers can turn on a debug flag and see where their code needs to be updated, but users aren't troubled by it. But in this case, we want the user to see it.

@takluyver

takluyver Oct 12, 2012

Owner

I'd say we shouldn't use DeprecationWarning for that reason. The idea is that developers can turn on a debug flag and see where their code needs to be updated, but users aren't troubled by it. But in this case, we want the user to see it.

@takluyver

This comment has been minimized.

Show comment Hide comment
@takluyver

takluyver Oct 12, 2012

Owner

I agree with @asmeurer that it would be good to mention its status in the module docstring as well. Other than that, this looks fine.

Owner

takluyver commented Oct 12, 2012

I agree with @asmeurer that it would be good to mention its status in the module docstring as well. Other than that, this looks fine.

@minrk

This comment has been minimized.

Show comment Hide comment
@minrk

minrk Oct 14, 2012

Owner

@asmeurer requested that this PR be applied to 0.13.1, is that correct?

Owner

minrk commented Oct 14, 2012

@asmeurer requested that this PR be applied to 0.13.1, is that correct?

Add deprecation warnings for sympyprinting
The sympyprinting extension has been moved to SymPy as of version 0.7.2.
For versions containing the new extension, print a deprecation warning
and load the extension from SymPy.
@flacjacket

This comment has been minimized.

Show comment Hide comment
@flacjacket

flacjacket Oct 14, 2012

Contributor

@takluyver @asmeurer I've added the note about the status to the docstring.

@minrk Yes, Aaron had mentioned adding this PR to start deprecating on your end as SymPy takes on the printing extension.

Contributor

flacjacket commented Oct 14, 2012

@takluyver @asmeurer I've added the note about the status to the docstring.

@minrk Yes, Aaron had mentioned adding this PR to start deprecating on your end as SymPy takes on the printing extension.

@asmeurer

This comment has been minimized.

Show comment Hide comment
@asmeurer

asmeurer Oct 14, 2012

Contributor

It's not a huge deal, since you guys actually release pretty often, but it is always nice to start deprecation cycles. But it's your decision.

Contributor

asmeurer commented Oct 14, 2012

It's not a huge deal, since you guys actually release pretty often, but it is always nice to start deprecation cycles. But it's your decision.

@minrk

This comment has been minimized.

Show comment Hide comment
@minrk

minrk Oct 14, 2012

Owner

Okay, if this is finished and merged tomorrow then it will go in, otherwise no big deal to wait one more cycle.

Owner

minrk commented Oct 14, 2012

Okay, if this is finished and merged tomorrow then it will go in, otherwise no big deal to wait one more cycle.

@takluyver

This comment has been minimized.

Show comment Hide comment
@takluyver

takluyver Oct 14, 2012

Owner

Right, I think this is finished. Thanks, @flacjacket .

@minrk : I'm merging this now, can you take care of applying it to 0.13.1?

Owner

takluyver commented Oct 14, 2012

Right, I think this is finished. Thanks, @flacjacket .

@minrk : I'm merging this now, can you take care of applying it to 0.13.1?

takluyver added a commit that referenced this pull request Oct 14, 2012

Merge pull request #2480 from flacjacket/move_sympyprinting
Add deprecation warnings for sympyprinting

@takluyver takluyver merged commit f448b5c into ipython:master Oct 14, 2012

1 check passed

default The Travis build passed
Details

minrk added a commit that referenced this pull request Oct 14, 2012

Backport PR #2480: Add deprecation warnings for sympyprinting
The sympyprinting extension has been moved to SymPy for the upcoming 0.7.2 release (see sympy/sympy#1559). For versions containing the new extension, print a deprecation warning and load the extension from SymPy.
@minrk

This comment has been minimized.

Show comment Hide comment
@minrk

minrk Oct 14, 2012

Owner

applied to 0.13.1

Owner

minrk commented Oct 14, 2012

applied to 0.13.1

mindw added a commit to mindw/ipython that referenced this pull request Oct 18, 2012

Backport PR #2480: Add deprecation warnings for sympyprinting
The sympyprinting extension has been moved to SymPy for the upcoming 0.7.2 release (see sympy/sympy#1559). For versions containing the new extension, print a deprecation warning and load the extension from SymPy.

yarikoptic added a commit to yarikoptic/ipython that referenced this pull request May 2, 2014

Merge tag 'rel-0.13.1' into debian-01X
* tag 'rel-0.13.1': (27 commits)
  remove rc for 0.13.1 final
  0.13.1.rc3
  qtconsole extras_require to whatsnew
  Backport PR #2492: add missing 'qtconsole' extras_require
  add 2480 to whatsnew
  Backport PR #2480: Add deprecation warnings for sympyprinting
  PR 2384 to whatsnew
  mark 0.13.1.rc2
  Backport PR #2384: Adapt inline backend to changes in matplotlib
  mark 0.13.1.rc1
  update 0.13.1 whatsnew lists
  Backport PR #2479: use new _winapi instead of removed _subprocess
  Backport PR #2437: don't let log cleanup prevent engine start
  Backport PR #2405: clarify TaskScheduler.hwm doc
  Backport PR #2377: Fix installation of man pages in Python 3
  start 0.13.1 whatsnew
  Backport PR #2373: fix missing imports in core.interactiveshell
  Backport PR #2365: fix names of notebooks for download/save
  Backport PR #2345: Remove references to 'version' no longer in argparse. Github issue #2343.
  Backport PR #2347: adjust division error message checking to account for Python 3
  ...

yarikoptic added a commit to yarikoptic/ipython that referenced this pull request May 2, 2014

Merge tag 'rel-0.13.1' (mtheirs) into releases
* tag 'rel-0.13.1': (51 commits)
  remove rc for 0.13.1 final
  0.13.1.rc3
  qtconsole extras_require to whatsnew
  Backport PR #2492: add missing 'qtconsole' extras_require
  add 2480 to whatsnew
  Backport PR #2480: Add deprecation warnings for sympyprinting
  PR 2384 to whatsnew
  mark 0.13.1.rc2
  Backport PR #2384: Adapt inline backend to changes in matplotlib
  mark 0.13.1.rc1
  update 0.13.1 whatsnew lists
  Backport PR #2479: use new _winapi instead of removed _subprocess
  Backport PR #2437: don't let log cleanup prevent engine start
  Backport PR #2405: clarify TaskScheduler.hwm doc
  Backport PR #2377: Fix installation of man pages in Python 3
  start 0.13.1 whatsnew
  Backport PR #2373: fix missing imports in core.interactiveshell
  Backport PR #2365: fix names of notebooks for download/save
  Backport PR #2345: Remove references to 'version' no longer in argparse. Github issue #2343.
  Backport PR #2347: adjust division error message checking to account for Python 3
  ...

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2480 from flacjacket/move_sympyprinting
Add deprecation warnings for sympyprinting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment