trigger default remote_profile_dir when profile_dir is set #2511

Merged
merged 1 commit into from Nov 1, 2012

Conversation

Projects
None yet
2 participants
@minrk
Owner

minrk commented Oct 22, 2012

in SSHLaunchers

remote_profile_dir_default could be triggered before profile_dir was set,
resulting in an empty remote_profile_dir, causing failures.

trigger default remote_profile_dir when profile_dir is set
in SSHLaunchers

remote_profile_dir_default could be triggered before profile_dir was set,
resulting in an empty remote_profile_dir, causing failures.
@ellisonbg

This comment has been minimized.

Show comment Hide comment
@ellisonbg

ellisonbg Nov 1, 2012

Owner

This is pretty simple and the code looks fine. Go ahead and merge this.

Owner

ellisonbg commented Nov 1, 2012

This is pretty simple and the code looks fine. Go ahead and merge this.

minrk added a commit that referenced this pull request Nov 1, 2012

Merge pull request #2511 from minrk/remote_profile_dir
trigger default remote_profile_dir when profile_dir is set

n SSHLaunchers

remote_profile_dir_default could be triggered before profile_dir was set, 
resulting in an empty remote_profile_dir, causing failures.

@minrk minrk merged commit a2229bb into ipython:master Nov 1, 2012

minrk added a commit that referenced this pull request Mar 5, 2013

Backport PR #2511: trigger default remote_profile_dir when profile_di…
…r is set

in SSHLaunchers

remote_profile_dir_default could be triggered before profile_dir was set,
resulting in an empty remote_profile_dir, causing failures.

@minrk minrk deleted the minrk:remote_profile_dir branch Mar 31, 2014

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2511 from minrk/remote_profile_dir
trigger default remote_profile_dir when profile_dir is set

n SSHLaunchers

remote_profile_dir_default could be triggered before profile_dir was set, 
resulting in an empty remote_profile_dir, causing failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment