Don't kill paramiko tunnels when receiving ^C #2526

merged 1 commit into from Nov 13, 2012


None yet

4 participants

minrk commented Oct 26, 2012

prevents ^C from being passed along to children, bringing them down

closes #2520

tomspur commented Nov 4, 2012

This version of spawn_pgrp seems to be modified quite heavily to call it an adaption and not a dependency of IPython.
Would it make sense to add such adaptions to IPython/adaptions instead of IPython/external?

It would be more clear, if there is a folder of copy&pasted dependencies in one folder, that live there for the sake of simplifying installing/running IPython, but are not (heavy) modified for use of IPython.

minrk commented Nov 4, 2012

What do you mean by modified quite heavily? The original file has two things:

  1. a generic subclass of pexpect.spawn that exposes setpgrp
  2. a utility function specific to the gridmon project

All I did was delete the function, as it makes no sense to keep it (trying to call it would just result in an ImportError). The class is unmodified.

But in #2520 @andreabedini said this doesn't even fix the issue (which I don't fully understand), so I think we should probably just close this and try something else.

minrk commented Nov 7, 2012

I realized that this problem never affected the pexpect case, so I've scrubbed the whole setpgrp thing. All that was needed here was signal.signal(signal.SIGINT, signal.SIG_IGN) in the tunnel function called in the forked process.

Carreau commented Nov 12, 2012

Do we wait for feedback from the author @andreabedini?


Hi, sorry I don't have much time to do tests. I'll try to get back in 24h
otherwise do without me.

On 12 November 2012 21:17, Bussonnier Matthias notifications@github.comwrote:

Do we wait for feedback from the author @andreabedini

Reply to this email directly or view it on GitHub

Andrea Bedini


This last patch fixes the problem for me. Thanks heaps.

Carreau commented Nov 13, 2012

Great. Merging.

@Carreau Carreau merged commit ecf061e into ipython:master Nov 13, 2012

1 check passed

default The Travis build passed
minrk commented Nov 13, 2012

Thanks, @Carreau and @andreabedini!

@minrk minrk added a commit that referenced this pull request Mar 5, 2013
@minrk minrk Backport PR #2526: Don't kill paramiko tunnels when receiving ^C
prevents ^C from being passed along to children, bringing them down

closes #2520
@minrk minrk deleted the minrk:setpgrp branch Mar 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment