Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Infinite loop when multiple debuggers have been attached. #2544

Merged
merged 2 commits into from Jan 2, 2013

Conversation

Projects
None yet
2 participants
Contributor

bfroehle commented Nov 2, 2012

Replaces pull-request #2388.

Fixed infinite loop on exit in the event of where multiple debuggers have been attached an there is an uncaught exception.

Test code:

from IPython.core.debugger import Tracer;
Tracer()
Tracer()
raise Exception

Pinging @DamianHeard to review.

Fixed infinite loop on exit in the event of where multiple debuggers …
…have been attached an there is an uncaught exception. I am in the process of submitting a similar patch for ipdb.

Great! Very happy with that.

Contributor

bfroehle commented Nov 2, 2012

Good. I've added a few comments. I'll let one of the core developers take a look at it, and hopefully it'll get merged this weekend.

Thanks again for your patience. I'm going to close #2388 in the mean time.

Brilliant!

I'm not sure what relationship (if any) you have with the ipdb but I'll try and get that project to take a look at the patch once it is finalized.

Thanks for your time. You've got a great project here!

Sent from my iPhone

On 03/11/2012, at 10:14 AM, "Bradley M. Froehle" notifications@github.com wrote:

Good. I've added a few comments. I'll let one of the core developers take a look at it, and hopefully it'll get merged this weekend.

Thanks again for your patience. I'm going to close #2388 in the mean time.


Reply to this email directly or view it on GitHub.

bfroehle added a commit that referenced this pull request Jan 2, 2013

Merge pull request #2544 from bfroehle/tracer_recursion
Infinite loop when multiple debuggers have been attached.

@bfroehle bfroehle merged commit ca39815 into ipython:master Jan 2, 2013

1 check passed

default The Travis build passed
Details

@bfroehle bfroehle deleted the bfroehle:tracer_recursion branch Jan 2, 2013

minrk added a commit that referenced this pull request Mar 5, 2013

Backport PR #2544: Infinite loop when multiple debuggers have been at…
…tached.

Replaces pull-request #2388.

Fixed infinite loop on exit in the event of where multiple debuggers have been attached an there is an uncaught exception.

Test code:

```python
from IPython.core.debugger import Tracer;
Tracer()
Tracer()
raise Exception
```

Pinging @DamianHeard to review.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2544 from bfroehle/tracer_recursion
Infinite loop when multiple debuggers have been attached.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment