Fix #2244 #2574

Merged
merged 3 commits into from Nov 17, 2012

Conversation

Projects
None yet
4 participants
@dkua
Contributor

dkua commented Nov 13, 2012

Reformatted the warning message as per the issue and changed some of the original logic to be more readable as advised by Fernando.

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Nov 13, 2012

Member

Test results for commit 614ba8c merged into master (ecf061e)
Platform: linux2

  • python2.7: OK (libraries not available: azure)
  • python3.2: OK (libraries not available: azure cython matplotlib oct2py pygments pymongo rpy2 wx wx.aui)

Not available for testing: python2.6

Member

fperez commented Nov 13, 2012

Test results for commit 614ba8c merged into master (ecf061e)
Platform: linux2

  • python2.7: OK (libraries not available: azure)
  • python3.2: OK (libraries not available: azure cython matplotlib oct2py pygments pymongo rpy2 wx wx.aui)

Not available for testing: python2.6

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Nov 13, 2012

Member

This looks good, but before we merge it, you should rebase it and remove commits 2928c78 and fe022e5 from the history, since they have nothing to do with this problem and they just undo one another, so they're just noise in the history.

Member

fperez commented Nov 13, 2012

This looks good, but before we merge it, you should rebase it and remove commits 2928c78 and fe022e5 from the history, since they have nothing to do with this problem and they just undo one another, so they're just noise in the history.

- 'but not using any encryption or authentication. This is highly '
- 'insecure and not recommended.')
-
+ if not self.ip:

This comment has been minimized.

@bfroehle

bfroehle Nov 13, 2012

Contributor

You have accidentally changed the logic here so that it'll print warning messages almost always:

WARNING: The notebook server is listening on all IP addresses. This is highly insecure and not recommended.

I don't think that is intentional.

@bfroehle

bfroehle Nov 13, 2012

Contributor

You have accidentally changed the logic here so that it'll print warning messages almost always:

WARNING: The notebook server is listening on all IP addresses. This is highly insecure and not recommended.

I don't think that is intentional.

@bfroehle

This comment has been minimized.

Show comment
Hide comment
@bfroehle

bfroehle Nov 13, 2012

Contributor

For clarity: what situations do we consider insecure?

Contributor

bfroehle commented Nov 13, 2012

For clarity: what situations do we consider insecure?

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Nov 13, 2012

Member

@bfroehle, good catch.

Insecure:

  • Public IP without SSL should prompt a warning.
  • Public IP in read-write mode and no password, also a warning.

And perhaps, as you mentioned in #2244, it should indeed be split into two messages...

Member

fperez commented Nov 13, 2012

@bfroehle, good catch.

Insecure:

  • Public IP without SSL should prompt a warning.
  • Public IP in read-write mode and no password, also a warning.

And perhaps, as you mentioned in #2244, it should indeed be split into two messages...

@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Nov 16, 2012

Member

The new logic seem fine to me and seem to do what Fernando asked.

@dkua, we don't get notified of new push, so we haven't seen your updates. Don't hesitate to ping us if we don't reply.

Member

Carreau commented Nov 16, 2012

The new logic seem fine to me and seem to do what Fernando asked.

@dkua, we don't get notified of new push, so we haven't seen your updates. Don't hesitate to ping us if we don't reply.

@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Nov 17, 2012

Member

I'll go ahead and merge.

Member

Carreau commented Nov 17, 2012

I'll go ahead and merge.

Carreau added a commit that referenced this pull request Nov 17, 2012

Merge pull request #2574 from dkua/Fix#2244
Reformatted the warning message of notebook server starting.

Public IP without SSL should prompt a warning.
Public IP in read-write mode and no password, also a warning.

Fix #2244

@Carreau Carreau merged commit 4e73029 into ipython:master Nov 17, 2012

minrk added a commit that referenced this pull request Mar 5, 2013

Backport PR #2574: Fix #2244
Reformatted the warning message as per the issue and changed some of the original logic to be more readable as advised by Fernando.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2574 from dkua/Fix#2244
Reformatted the warning message of notebook server starting.

Public IP without SSL should prompt a warning.
Public IP in read-write mode and no password, also a warning.

Fix #2244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment