GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformatted the warning message as per the issue and changed some of the original logic to be more readable as advised by Fernando.
Test results for commit 614ba8c merged into master (ecf061e)
Not available for testing: python2.6
This looks good, but before we merge it, you should rebase it and remove commits 2928c78 and fe022e5 from the history, since they have nothing to do with this problem and they just undo one another, so they're just noise in the history.
Refactored warning printout as per Issue #2244
Made some changes to message and logic as advised by Fernando.
You have accidentally changed the logic here so that it'll print warning messages almost always:
WARNING: The notebook server is listening on all IP addresses. This is highly insecure and not recommended.
I don't think that is intentional.
For clarity: what situations do we consider insecure?
@bfroehle, good catch.
And perhaps, as you mentioned in #2244, it should indeed be split into two messages...
Made changes as per discussion in PR thread.
The new logic seem fine to me and seem to do what Fernando asked.
@dkua, we don't get notified of new push, so we haven't seen your updates. Don't hesitate to ping us if we don't reply.
I'll go ahead and merge.
Merge pull request #2574 from dkua/Fix#2244
Reformatted the warning message of notebook server starting.
Public IP without SSL should prompt a warning.
Public IP in read-write mode and no password, also a warning.
Backport PR #2574: Fix #2244