Skip to content

Notebook examples - Python 2 and 3 compatible #2627

Closed
wants to merge 2 commits into from

5 participants

@takluyver
IPython member

Make the example notebooks Python 2 and 3 compatible, so that Python 3 users can get started easily too.

Along the way, I found a couple of other minor issues in the notebooks, and a problem with Image() objects when created with data=b'...'.

Closes #2622.

@ellisonbg
IPython member
@pleabargain

@ellisonbg Brian, as I'm new to the block, would I have to install .14 dev in order to take advantage of your rewritten notebooks?

@bfroehle

Wow that's great. Everything looks good to me. +1 for merging.

@ellisonbg #2537 already does not merge cleanly... how much effort is required in rebasing it and fixing the conflicts?

@takluyver takluyver referenced this pull request in ellisonbg/ipython Nov 28, 2012
Merged

Examples py3 compat #6

@ellisonbg
IPython member
@takluyver
IPython member
@bfroehle

I have no opinion on the matter (docs/examples vs. examples).

@ellisonbg
IPython member
@minrk
IPython member
minrk commented Nov 29, 2012

I don't care about moving the examples out of the docs directory (benefit is negligible, and cost is minor), but in doing so, you must also take care of the literalinclude calls that currently depend on examples (update the paths, duplicate the files, or some such). An earlier rewrite of an example (options pricer, I think?) already broke one of these, so clearly people are not paying attention to this.

@ellisonbg
IPython member
@bfroehle
bfroehle commented Dec 7, 2012

Thanks @takluyver for the work here. Unless @ellisonbg thinks he will get to the notebook restructuring soon, I think we should consider merging this now.

@takluyver
IPython member
@ellisonbg
IPython member
@ellisonbg
IPython member

@takluyver I have merged your PR against my branch. I am going to finish the work on my branch now so we can merge it. Does this PR have anything in addition or can it be closed?

@takluyver
IPython member

Thanks Brian. Nope, it should be the same stuff. Closing this one.

@takluyver takluyver closed this Jan 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.