Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Improve Windows start menu shortcuts (#2) #2635

Merged
merged 3 commits into from Apr 13, 2013

Conversation

Projects
None yet
4 participants
Contributor

cgohlke commented Dec 1, 2012

This is a replacement for PR #2631.

  • Create Windows start menu shortcuts with better names.
  • Add shortcuts for IPython Notebook and online documentation.
  • Add icons for IPython console and notebook.
  • Apply PEP8 to ipython_win_post_install.py.
  • Tested on win32-py2.7, win-amd64-py2.7, win-amd64-py3.3, Windows 8.
Owner

Carreau commented Dec 1, 2012

Hi,

I'll have a look later,

Usually you don't need to open a new PR, you can just push on the branch on the current PR updates, and even force-push if you make incompatible changes. But it's OK.

Owner

ellisonbg commented Jan 14, 2013

Can we close #2631 ?

Owner

minrk commented Jan 18, 2013

I would remove the --pylab inline launchers for the notebook, and maybe the QtConsole.
I think we should encourage using %pylab inline in notebooks instead (IPython's own example notebooks stopped assuming --pylab inline a while ago, because it was confusing people).

Owner

ellisonbg commented Feb 20, 2013

But leave the --pylab for the PyLab mode of the terminal?

Owner

ellisonbg commented Feb 20, 2013

We would like to move forward with this PR. Here is what I see needs to be done:

  • Someone needs to test this on Windows
  • Remove PyLab mode shortcuts for Notebook and QtConsole

@minrk minrk and 1 other commented on an outdated diff Apr 6, 2013

scripts/ipython_win_post_install.py
+ arguments(scripts, 'ipcontroller'), iconpath)
+ mkshortcut(python, 'IPython Engine', ip_start_menu,
+ arguments(scripts, 'ipengine'), iconpath)
+ mkshortcut(pythonw, 'IPython Qt Console', ip_start_menu,
+ arguments(scripts, 'ipython', 'qtconsole'), iconpath)
+
+ iconpath = pjoin(scripts, 'ipython_nb.ico')
+ mkshortcut(python, 'IPython Notebook', ip_start_menu,
+ arguments(scripts, 'ipython', 'notebook'), iconpath)
+
+ try:
+ import IPython
+ mkshortcut(pythonw, 'IPython Documentation', ip_start_menu,
+ '-m webbrowser -t "http://ipython.org/ipython-doc/'
+ 'rel-%s/index.html"' % IPython.__version__,
+ iconpath='url.dll')
@minrk

minrk Apr 6, 2013

Owner

This won't work unless the installer is run after IPython has already been installed, right? Why not replace this with either hardcoded stable, or just link to ipython.org/documentation.html?

@cgohlke

cgohlke Apr 13, 2013

Contributor

This is a post_install script so IPython is installed when it is executed by the bdist_wininst installer. This patch directly addresses the FIXME at https://github.com/ipython/ipython/blob/0.13.x/scripts/ipython_win_post_install.py#L124 but I am not opposed to using ipython.org/documentation.html.

@minrk

minrk Apr 13, 2013

Owner

Thanks for the explanation, I'm a total novice in Windows things. I don't think this needs to change.

@cgohlke

cgohlke Apr 13, 2013

Contributor

Another thing to consider is that this will fail to create usable shortcuts for non-final releases e.g. betas or RCs, which don't have a specific online documentation URL.

@minrk

minrk Apr 13, 2013

Owner

You know what, that's a good point. Why don't you just make it point to the base documentation page? That seems like a safer choice.

Owner

ellisonbg commented Apr 13, 2013

I would really like to see this merged soon. @cgohlke it looks like @minrk had some more feedback and then we need to get at least one other person to test it on Windows.

Contributor

cgohlke commented Apr 13, 2013

This patch is part of my unofficial Scipy-stack and Ipython installers for several months if anyone wants to try.

Owner

minrk commented Apr 13, 2013

Okay, I think all review is addressed - I will just do a quick check installing on my local VM to confirm, then merge.

Thanks for your patience!

Owner

minrk commented Apr 13, 2013

terrific, thanks!

minrk added a commit that referenced this pull request Apr 13, 2013

Merge pull request #2635 from cgohlke/windows-startmenu
Improve Windows start menu shortcuts

* Create Windows start menu shortcuts with better names.
* Add shortcuts for IPython Notebook and online documentation.
* Add icons for IPython console and notebook.
* Apply PEP8 to ipython_win_post_install.py.
* Tested on win32-py2.7, win-amd64-py2.7, win-amd64-py3.3, Windows 8.

@minrk minrk merged commit e9bfcd7 into ipython:master Apr 13, 2013

1 check passed

default The Travis build passed
Details

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2635 from cgohlke/windows-startmenu
Improve Windows start menu shortcuts

* Create Windows start menu shortcuts with better names.
* Add shortcuts for IPython Notebook and online documentation.
* Add icons for IPython console and notebook.
* Apply PEP8 to ipython_win_post_install.py.
* Tested on win32-py2.7, win-amd64-py2.7, win-amd64-py3.3, Windows 8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment