OSX-specific fixes to the Qt console #266

Merged
3 commits merged into from Feb 10, 2011

Conversation

Projects
None yet
3 participants
Contributor

epatters commented Feb 10, 2011

Fixed a couple bugs reported by Darren Dale and MinRK on the mailing list.

Contributor

epatters commented Feb 10, 2011

I've added another commit to fix issue 173.

Owner

fperez commented Feb 10, 2011

The changes look good to me, but I don't have a mac to (easily) test on so it would be best if a mac user takes them for a spin before we merge them.

Evan, thanks for the good work!

One minor note: when a commit fixes a bug (like the one for 173), please add a line like:

Closes gh-173.

That way, when the commit is merged github will automatically close the bug for us :)

Owner

minrk commented Feb 10, 2011

fix confirmed on my machine, thanks Evan!

Owner

fperez commented Feb 10, 2011

Awesome. Evan, go ahead with the merge then, and please don't forget to close 173 and any other issues that might need manual closing this time around (for the future, the 'closes gh-XXX' trick works great).

Thanks for the work!

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment