Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix tox.ini #2686

Merged
merged 1 commit into from Dec 16, 2012

Conversation

Projects
None yet
4 participants
Contributor

tkf commented Dec 15, 2012

Prior to this patch, test for Python 3.2 failed.

Also, arguments can be passed to iptest via tox command now.
e.g.: tox -- IPython.core

Probably it makes sense to change .travis.yml to something like:

language: python
before_install:
    - pip install tox
script:
    - tox

Or you can use tox -e ... to run the tests parallel for each Python version.

Fix tox.ini
Prior to this patch, test for Python 3.2 failed.

Also, arguments can be passed to iptest via tox command now.
e.g.: `tox -- IPython.core`
Owner

takluyver commented Dec 15, 2012

That looks sensible to me. At some point we'll also want to add a py33 environment to that list, but it doesn't seem tox supports that yet.

Owner

Carreau commented Dec 16, 2012

So is there anything to add ? Or is it ok to merge ?

Owner

takluyver commented Dec 16, 2012

I think it can be merged, if you're happy too.

Contributor

tkf commented Dec 16, 2012

I am happy with it.

Owner

takluyver commented Dec 16, 2012

OK, I'm pressing the big green button :-)

takluyver added a commit that referenced this pull request Dec 16, 2012

@takluyver takluyver merged commit 9eb3363 into ipython:master Dec 16, 2012

1 check passed

default The Travis build passed
Details
Contributor

bfroehle commented Dec 16, 2012

Great. For what it's worth py33 support is available in the development branch of tox: https://bitbucket.org/hpk42/tox/commits/309c81d74decfc270ed2013449d8da71d12cb68c

minrk added a commit that referenced this pull request Mar 5, 2013

Backport PR #2686: Fix tox.ini
Prior to this patch, test for Python 3.2 failed.

Also, arguments can be passed to iptest via tox command now.
e.g.: `tox -- IPython.core`

Probably it makes sense to change .travis.yml to something like:

```
language: python
before_install:
    - pip install tox
script:
    - tox
```

Or you can use `tox -e ...` to run the tests parallel for each Python version.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment