%Rpush: Look for variables in the local scope first. #2731

Merged
merged 2 commits into from Jan 2, 2013

Projects

None yet

3 participants

@bfroehle
Contributor
bfroehle commented Jan 2, 2013

This is intended as a cleaned up version of #2698 & #2552, which partially addresses the issue in #2550.

The issue had two components:

  1. The %Rpush line magic did not look for variables in the local scope.
  2. The %Rpush line magic expected variable names to be separated with spaces.

This pull request addresses only the first of these two issues. I feel that the issues are sufficiently different to deserve separate consideration (and separate pull requests). In particular, %Rpull currently requires variable names to be separated by spaces as well and I think we should ensure that the semantics for %Rpush and %Rpull remain identical.

I'm going to close #2698 and link to this issue.

@bfroehle
Contributor
bfroehle commented Jan 2, 2013

Test results for commit 5e268bb merged into master (ca39815)
Platform: linux2

  • python2.7: OK (libraries not available: azure)
  • python3.2: OK (libraries not available: azure jinja2 oct2py pymongo rpy2 wx wx.aui)

Not available for testing: python2.6

@takluyver
Member

Looks good to me.

@bfroehle bfroehle merged commit 399d860 into ipython:master Jan 2, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment