can interactively defined classes #2755

Merged
merged 3 commits into from Jan 11, 2013

Conversation

Projects
None yet
3 participants
@minrk
Member

minrk commented Jan 7, 2013

as proposed in #2754

Only interactively defined classes are canned.

closes #2754

@ogrisel

This comment has been minimized.

Show comment
Hide comment
@ogrisel

ogrisel Jan 7, 2013

Contributor

I just tried your branch and I confirm it fixes the notebook example I submitted in #2754. Thanks

Contributor

ogrisel commented Jan 7, 2013

I just tried your branch and I confirm it fixes the notebook example I submitted in #2754. Thanks

@ellisonbg

This comment has been minimized.

Show comment
Hide comment
@ellisonbg

ellisonbg Jan 9, 2013

Member

This code has tests that pass, and the user confirmed it fixes the issue. I would go ahead and merge.

Member

ellisonbg commented Jan 9, 2013

This code has tests that pass, and the user confirmed it fixes the issue. I would go ahead and merge.

@ogrisel

This comment has been minimized.

Show comment
Hide comment
@ogrisel

ogrisel Jan 9, 2013

Contributor

I don't know the change-log policy for the IPython project but should not that be documented somewhere, maybe in the whats new section of the doc?

Contributor

ogrisel commented Jan 9, 2013

I don't know the change-log policy for the IPython project but should not that be documented somewhere, maybe in the whats new section of the doc?

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Jan 10, 2013

Member

For little bugfixes like this, I think the generated GitHub summary that goes in whatsnew is sufficient.

Member

minrk commented Jan 10, 2013

For little bugfixes like this, I think the generated GitHub summary that goes in whatsnew is sufficient.

minrk added a commit that referenced this pull request Jan 11, 2013

Merge pull request #2755 from minrk/canclass
can interactively defined classes

*Only* interactively defined classes are canned.

closes #2754

@minrk minrk merged commit e8c3ce5 into ipython:master Jan 11, 2013

1 check passed

default The Travis build passed
Details

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2755 from minrk/canclass
can interactively defined classes

*Only* interactively defined classes are canned.

closes #2754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment