in %edit, don't save "last_call" unless last call succeeded #2816

Merged
merged 1 commit into from Jan 20, 2013

Conversation

Projects
None yet
3 participants
@minrk
Owner

minrk commented Jan 19, 2013

avoids failing calls to %edit from killing future %edit -p

closes #2466

in %edit, don't save "last_call" unless last call succeeded
avoids failing calls to `%edit` from killing future `%edit -p`

closes #2466
@takluyver

This comment has been minimized.

Show comment Hide comment
@takluyver

takluyver Jan 19, 2013

Owner

Looks good to me, and I imagine we can't easily add a test. Let's give it a day or so for anyone else to have a check, and then merge it.

Owner

takluyver commented Jan 19, 2013

Looks good to me, and I imagine we can't easily add a test. Let's give it a day or so for anyone else to have a check, and then merge it.

@doda

This comment has been minimized.

Show comment Hide comment
@doda

doda Jan 20, 2013

I'm the author of #2466 and it does indeed fix that. Thanks minrk!

doda commented Jan 20, 2013

I'm the author of #2466 and it does indeed fix that. Thanks minrk!

@takluyver

This comment has been minimized.

Show comment Hide comment
@takluyver

takluyver Jan 20, 2013

Owner

Great, I'll merge this, then.

Owner

takluyver commented Jan 20, 2013

Great, I'll merge this, then.

takluyver added a commit that referenced this pull request Jan 20, 2013

Merge pull request #2816 from minrk/edit_last_cell
in %edit, don't save "last_call" unless last call succeeded

@takluyver takluyver merged commit e81ebf3 into ipython:master Jan 20, 2013

1 check passed

default The Travis build passed
Details

minrk added a commit that referenced this pull request Mar 5, 2013

Backport PR #2816: in %edit, don't save "last_call" unless last call …
…succeeded

avoids failing calls to `%edit` from killing future `%edit -p`

closes #2466

@minrk minrk deleted the minrk:edit_last_cell branch Mar 31, 2014

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2816 from minrk/edit_last_cell
in %edit, don't save "last_call" unless last call succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment