Don't die if stderr/stdout do not support set_parent() #2925 #2926

Merged
merged 1 commit into from Feb 13, 2013

Projects

None yet

2 participants

@y-p
y-p commented Feb 12, 2013

If the user redirects the streams to a file for example,
the kernel would raise an exception because file
objects do not have set_parent defined, unlike ipython's
OutStream.
This happens even if the user does this in a spawned thread.

closes #2925

@minrk
Member
minrk commented Feb 12, 2013

set_parent is also called on L576-577

@y-p y-p Don't die if stderr/stdout do not support set_parent() #2925
If the user redirects the streams to a file for example,
the kernel would raise an exception because file
objects do not have set_parent defined, unlike ipython's
OutStream.
This happens even if the user does this in a spawned thread.
9deb416
@y-p
y-p commented Feb 12, 2013

thank you, fixed.

@minrk
Member
minrk commented Feb 13, 2013

simple enough, merging. Thanks!

@minrk minrk merged commit 465f43c into ipython:master Feb 13, 2013

1 check passed

Details default The Travis build passed
@y-p
y-p commented Feb 13, 2013

45 minutes from hitting a bug to upstream fixed. This is why I love open-source.

@minrk
Member
minrk commented Feb 13, 2013

it's nice when it works out.

@minrk minrk added a commit that referenced this pull request Mar 5, 2013
@minrk minrk Backport PR #2926: Don't die if stderr/stdout do not support set_pare…
…nt() #2925

If the user redirects the streams to a file for example,
the kernel would raise an exception because file
objects do not have set_parent defined, unlike ipython's
OutStream.
This happens even if the user does this in a spawned thread.

closes #2925
01f1179
@minrk minrk added a commit that referenced this pull request Mar 20, 2013
@minrk minrk Backport PR #2926: Don't die if stderr/stdout do not support set_pare…
…nt() #2925

If the user redirects the streams to a file for example,
the kernel would raise an exception because file
objects do not have set_parent defined, unlike ipython's
OutStream.
This happens even if the user does this in a spawned thread.

closes #2925
f85e1f8
@y-p y-p deleted the unknown repository branch Jan 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment