storemagic extension enhancement #3015

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

shuga commented Mar 12, 2013

- List stored aliases can be displayed by %store
- Variables and aliasses can be deleted or refreshed by name - %store -d or %store -r accordingly
- %store -r also restores stored aliases
- %store -h restores %dhist
- %store -z has been replaced by %store -d
@shuga shuga storemagic extension enhancement.
    - List stored aliases can be displayed by %store
    - Variables and aliasses can be deleted or refreshed by name - %store -d or %store -r accordingly
    - %store -r also restores stored aliases
    - %store -h restores %dhist
    - %store -z has been replaced by %store -d
9861722
Owner

Carreau commented Mar 12, 2013

Hi,

Didn't look deeplly into the code but :

  • test are failing, cannot load store magic anymore.
  • I would at least leave -z as a -d alias (not sure why you changed -z for -d I don't have any preferences)
  • You don't need to track the _loaded state of an extension. IPython do it by himself now.

I don't use store myself, so I will wait fo other dev feedback.

Owner

Carreau commented Mar 12, 2013

Oh, and Thanks for the contribution ! feel free to ask if you have any question,
It's too early in the morning, I forgot my manners :-)

@takluyver takluyver commented on the diff Mar 12, 2013

IPython/extensions/storemagic.py
@@ -28,33 +28,37 @@
from IPython.core.error import UsageError
from IPython.core.fakemodule import FakeModule
from IPython.core.magic import Magics, magics_class, line_magic
+from IPython.core.plugin import Plugin
@takluyver

takluyver Mar 12, 2013

Owner

IPython.core.plugin has been removed, so this won't work.

Owner

takluyver commented Mar 12, 2013

It looks like you might have edited storemagic from an older version of IPython, and copied it over the version in master, because it reintroduces various things that had been removed (like IPython.core.plugin and the _loaded flag).

Owner

ellisonbg commented Apr 10, 2013

@shuga hi, I am wondering that the status of this work is? Were you planning on continuing it? Do you feel like you need further review before continuing? We like to keep our pull request queue moving. If you aren't going to work on this right for a while, we would probably close the PR - you could always reopen it if you restarted work at some later point. Let us know what you are thinking and thanks for your work. Cheers, Brian

Owner

ellisonbg commented Apr 12, 2013

I am going to close this PR do to inactivity. Please feel free to reopen at any time when work restarts.

Owner

ellisonbg commented Apr 12, 2013

Closing until work restarts. I have opened issue #3167 to track this work.

ellisonbg closed this Apr 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment