Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

History memory #312

Merged
merged 1 commit into from Mar 25, 2011

Conversation

Projects
None yet
3 participants
Contributor

rkern commented Mar 25, 2011

Use a :memory: DB for history during testing.

@fperez fperez merged commit 62118c7 into ipython:master Mar 25, 2011

Owner

fperez commented Mar 25, 2011

Awesome, many thanks! The .core test time went from ~30 secs to 2 secs on my machine, so this really is significant. Great job, as always.

@takluyver takluyver commented on the diff Mar 25, 2011

IPython/core/history.py
@@ -47,15 +47,22 @@ class HistoryManager(Configurable):
input_hist_raw = List([""])
# A list of directories visited during session
dir_hist = List()
+ def _dir_hist_default(self):
@takluyver

takluyver Mar 25, 2011

Owner

Does this method get automatically picked up by traits to set the default?

@rkern

rkern Mar 25, 2011

Contributor

Yes.

Owner

takluyver commented Mar 25, 2011

This looks fine to me, but I've been too slow with reviewing it, and it's already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment