Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Notebook CasperJS tests #3125

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
5 participants
Contributor

dwyde commented Apr 2, 2013

[ not for 1.0 ]

This PR is a starting point for testing the notebook with CasperJS.

See also:
https://github.com/ipython/ipython/wiki/IPEP-14:-Notebook-Regression-Tests

Owner

ellisonbg commented Apr 3, 2013

I am +1 on this idea - will try to provide some details code review soon.

Owner

Carreau commented Apr 3, 2013

Hi,

Reviewd from my phone so far frim perfect, I mainly have question.

When is the test triggerd? On page load? Could it wait for notebook loaded
event?

About keypress, would it be possible to import IPython utils.js that have a
few key values defined?

Thanks!
Le 3 avr. 2013 04:19, "Brian E. Granger" notifications@github.com a
écrit :

I am +1 on this idea - will try to provide some details code review soon.


Reply to this email directly or view it on GitHubhttps://github.com/ipython/ipython/pull/3125#issuecomment-15814130
.

Contributor

dwyde commented Apr 3, 2013

Each test starts in an empty browser, then openNewNotebook() loads the notebook page.

Good point about key codes, and it looks like they're already in jQuery UI.

Owner

ellisonbg commented Sep 20, 2013

OK for this PR we get the "worse code review responsiveness of the year" award. Paul, you are the lead on our JavaScript testing work for 2.0. It would be great to get that work started. Could you have a look at this PR and maybe use it as a started point for that?

Owner

ellisonbg commented Sep 20, 2013

Opps, I meant to ping @ivanov in my last comment, not just mention his name...

Owner

ivanov commented Sep 20, 2013

on it - this morning I actually started to pick back up the work on dexy that we started back at the dev meeting, and came to this PR just now to review what had happened here.

Owner

ellisonbg commented Sep 20, 2013

Thanks!

ivanov added a commit to ivanov/ipython that referenced this pull request Sep 26, 2013

@ellisonbg ellisonbg referenced this pull request Sep 26, 2013

Merged

Notebook javascript test suite using CasperJS #4285

11 of 15 tasks complete
Owner

minrk commented Sep 27, 2013

this work will be finished up in #4285

@minrk minrk closed this Sep 27, 2013

ivanov added a commit to ivanov/ipython that referenced this pull request Oct 23, 2013

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment