Usability improvements to history in Qt console #356

Merged
merged 2 commits into from Apr 11, 2011

Conversation

Projects
None yet
2 participants
Contributor

epatters commented Apr 11, 2011

I have implemented readline-style history saving and optional (off by default) history locking as discussed in #338.

@fperez
I have used Shift as the modifier for overriding the history lock. This is symmetric with the Shift+Enter keybinding, which I like, but it also means that Shift+Up/Down are context-sensitive: they perform text selection if not on the first/last lines. I considered using Ctrl, but then Ctrl+P and Ctrl+N would not be supported properly, which I don't like. That leaves Alt and Meta, but both are more obscure and more difficult to press than Shift or Ctrl. In short, I am paralyzed by indecision :)

Owner

fperez commented Apr 11, 2011

This looks awesome, thanks!

When we get proper config support for the console it will be easy for users to set their preference, let's leave it as is for now.

Only one question: is it easy to somehow provide visual indication if the cell is 'locked'? Something like changing the background color or adding a thin line above it to indicate the cursor now has a 'wall'?

If something like that is easy to add, it would be a great addition. If not, go ahead and merge and push.

Many thanks for this! I'll make new issues for any other usability points I find.

Contributor

epatters commented Apr 11, 2011

I do think a faint background color would be a nice way to indicate that the buffer is locked, but since this is fairly non-trivial I'm going to hold off on it for now.

Feel free to create a low-priority ticket for this if you like.

Owner

fperez commented Apr 11, 2011

OK, no prob. Then go ahead and merge, I'll make the ticket, prio-low, tagged to you.

@epatters epatters merged commit 66c6673 into ipython:master Apr 11, 2011

Owner

fperez commented Apr 11, 2011

Done as #358.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment