Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fallback on defaultencoding if filesystemencoding is None #362

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

minrk commented Apr 11, 2011

closes gh-137

sys.getfilesystemencoding() could be None, which when passed to decode would raise. filesystemencoding now falls back to defaultencoding if None, which can't (as far as I can tell) be undefined. I could add a secondary 'ascii' fallback, if that is possible.

Owner

takluyver commented Apr 11, 2011

I'm inclined to leave the second fallback unless we know of some situation in which it's needed.

Owner

minrk commented Apr 19, 2011

closing as superceded by #393

@minrk minrk closed this Apr 19, 2011

@takluyver takluyver referenced this pull request Apr 29, 2011

Closed

ipdir unicode #393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment