Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Issue 125 #363

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Owner

minrk commented Apr 11, 2011

run_cell(exec_lines) is now called with 'store_history=False'

This prevents config file defined exec_lines from showing up
in the history, and results in input counter always starting at 1

closes gh-125

run_cell(exec_lines) now called with 'store_history=False'
This prevents config file defined exec_lines from showing up
in the history, and results in input counter always starting at 1

closes gh-125
Owner

takluyver commented Apr 11, 2011

Looks sensible to me.

Owner

minrk commented Apr 12, 2011

The only reason not to merge this right now is that the change is in an application, and @ellisonbg is making changes to config/application logic. But this is obviously tiny.

Owner

fperez commented Apr 12, 2011

@minrk, I don't think that Brian is doing anything quite yet on the config stuff, and this bug is really annoying in practice. The change is tiny and correct, so go ahead and merge. Thanks!

@minrk minrk closed this in 74721c4 Apr 12, 2011

Owner

ellisonbg commented Apr 12, 2011

Yes, I would merge this.

On Mon, Apr 11, 2011 at 6:11 PM, fperez
reply@reply.github.com
wrote:

@minrk, I don't think that Brian is doing anything quite yet on the config stuff, and this bug is really annoying in practice.  The change is tiny and correct, so go ahead and merge.  Thanks!

Reply to this email directly or view it on GitHub:
#363 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

Owner

minrk commented Apr 12, 2011

great, merged and pushed.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

run_cell(exec_lines) now called with 'store_history=False'
This prevents config file defined exec_lines from showing up
in the history, and results in input counter always starting at 1

closes gh-125
closes gh-363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment