Skip to content

Loading…

Issue 125 #363

Closed
wants to merge 1 commit into from

4 participants

@minrk
IPython member

run_cell(exec_lines) is now called with 'store_history=False'

This prevents config file defined exec_lines from showing up
in the history, and results in input counter always starting at 1

closes gh-125

@minrk minrk run_cell(exec_lines) now called with 'store_history=False'
This prevents config file defined exec_lines from showing up
in the history, and results in input counter always starting at 1

closes gh-125
62acb42
@takluyver
IPython member

Looks sensible to me.

@minrk
IPython member

The only reason not to merge this right now is that the change is in an application, and @ellisonbg is making changes to config/application logic. But this is obviously tiny.

@fperez
IPython member

@minrk, I don't think that Brian is doing anything quite yet on the config stuff, and this bug is really annoying in practice. The change is tiny and correct, so go ahead and merge. Thanks!

@minrk minrk added a commit that closed this pull request
@minrk minrk run_cell(exec_lines) now called with 'store_history=False'
This prevents config file defined exec_lines from showing up
in the history, and results in input counter always starting at 1

closes gh-125
closes gh-363
74721c4
@minrk minrk closed this in 74721c4
@ellisonbg
IPython member
@minrk
IPython member

great, merged and pushed.

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request
@minrk minrk run_cell(exec_lines) now called with 'store_history=False'
This prevents config file defined exec_lines from showing up
in the history, and results in input counter always starting at 1

closes gh-125
closes gh-363
1471f6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 11, 2011
  1. @minrk

    run_cell(exec_lines) now called with 'store_history=False'

    minrk committed
    This prevents config file defined exec_lines from showing up
    in the history, and results in input counter always starting at 1
    
    closes gh-125
Showing with 2 additions and 2 deletions.
  1. +2 −2 IPython/frontend/terminal/ipapp.py
View
4 IPython/frontend/terminal/ipapp.py
@@ -570,7 +570,7 @@ def _run_exec_lines(self):
try:
self.log.info("Running code in user namespace: %s" %
line)
- self.shell.run_cell(line)
+ self.shell.run_cell(line, store_history=False)
except:
self.log.warn("Error in executing line in user "
"namespace: %s" % line)
@@ -615,7 +615,7 @@ def _run_cmd_line_code(self):
try:
self.log.info("Running code given at command line (-c): %s" %
line)
- self.shell.run_cell(line)
+ self.shell.run_cell(line, store_history=False)
except:
self.log.warn("Error in executing line in user namespace: %s" %
line)
Something went wrong with that request. Please try again.