Skip to content

change default behavior of database task storage #4080

Merged
merged 2 commits into from Sep 18, 2013

2 participants

@minrk
IPython member
minrk commented Aug 21, 2013

The previous default behavior was to create a new table (sqlite) / database (mongodb) for each Hub instance, so that task history would not be shared by subsequent IPython sessions.

I don't think this was the right choice, so this PR switches the default behavior to use the table / database ipython-tasks. The result is that all Hub sessions in a given profile will share history by default, which makes the benefit of the db backends clearer.

Configurable behavior remains the same, only the default is changed.

minrk added some commits Aug 21, 2013
@minrk minrk change default behavior of database task storage
The previous default behavior was to create a new table (sqlite) / database (mongodb) for each Hub instance,
so that task history would not be shared by subsequent IPython sessions.

I don't think this was the right choice,
so this PR switches the default behavior to use the table / database `ipython-tasks`.
The result is that all Hub sessions in a given profile will share history by default,
which makes the benefit of the db backends clearer.

Configurable behavior remains the same, only the default is changed.
8683a41
@minrk minrk quote table name
avoids syntax errors from hyphens
8ed2f5c
@minrk
IPython member
minrk commented Sep 3, 2013

Merging in 24 hours unless I hear otherwise.

@Carreau
IPython member
Carreau commented Sep 12, 2013

Merging in 24 hours unless I hear otherwise.

Same here. I know you don't like beeing at less that 5 opened PR so I'm reluctant to merge myself.

@minrk minrk merged commit fbb0174 into ipython:master Sep 18, 2013

1 check passed

Details default The Travis CI build passed
@minrk minrk deleted the minrk:task-history branch Mar 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.