Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bugfix with logger #455

Merged
merged 1 commit into from May 18, 2011

Conversation

Projects
None yet
2 participants
Contributor

luispedro commented May 18, 2011

Previously, if there was an error opening the file (e.g., permission denied),
then the object would end up in a state where log_active was True, but there
was no logfile. The result was constant errors.

Test case is attempting to use %logstart in a directory where you do not have permission to create a file.

BUG Move setting of log_active flag down
Previously, if there was an error opening the file (e.g., permission denied),
then the object would end up in a state where log_active was True, but there
was no logfile. The result was constant errors.

@takluyver takluyver merged commit 3fdc9a4 into ipython:master May 18, 2011

Owner

takluyver commented May 18, 2011

Thanks, Luis. I've also added an automated test for this (just by using an invalid filename). See this commit: 13fdc81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment