Skip to content

Add exit code when running all tests with iptest. #469

Merged
merged 2 commits into from May 25, 2011

3 participants

@takluyver
IPython member

Closes #468.

@minrk minrk and 1 other commented on an outdated diff May 24, 2011
IPython/testing/iptest.py
@@ -425,6 +425,8 @@ def run_iptestall():
print 'You may wish to rerun this one individually, with:'
print ' '.join(failed_runner.call_args)
print
+ # Ensure that our exit code indicates failure
+ sys.exit(1)
@minrk
IPython member
minrk added a note May 24, 2011

This is at the wrong scope - this will exit after the first failed section. It should be outside the for-loop.

@takluyver
IPython member
takluyver added a note May 24, 2011

Well spotted. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@takluyver
IPython member

Any more issues with this, anyone? @juliantaylor says it solves his issue, so I'll merge tomorrow unless anyone says otherwise.

@minrk
IPython member
minrk commented May 24, 2011

Yes, this is straightforward, and should be fine. Go ahead.

@takluyver takluyver merged commit 465180e into ipython:master May 25, 2011
@fperez
IPython member

Yup, this is the right place for the fix, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.