add QtConsoleApp using newapplication #491

Closed
wants to merge 28 commits into
from

Projects

None yet

4 participants

@minrk
IPython member

ipython-qtconsole now uses the newapplication and config system.

@fperez

Why do we need these to be classmethods?

IPython member

These are how ProfileDirs are created. See BaseIPApp.init_profile_dir().

IPython member

Never mind, too tired: I was thinking of staticmethods and got my brain wires crossed. Looks OK, sorry for the noise.

@fperez

Min pointed out that this PATH variable was a similar one to the one for cluster dirs, but I think it's worth reconsidering whether we truly need multiple PATH-style search variables for IPython. @ellisonbg, did you have some specific use cases in mind that warrant adding full-blown search paths to IPython, that couldn't be addressed with manual specification of the ipython/cluster/profile dir alone at the command line?

I just think that people go crazy enough with PYTHONPATH, LD_LIBRARY_PATH and other PATH variables in various systems, often leading to much confusion. So I think it's worth that we think a bit more about this one, and see if we can get away with no additional environment variables for IPython, especially not of the search path variety.

@minrk
IPython member

wrong pull target...

@minrk minrk closed this Jun 1, 2011
@epatters

The docstring has 'Inconsolata' as the Linux default, but the code has 'Anonymous Pro'. Typo?

IPython member

The default in Ubuntu is just called 'Monospace'. I think we should go with that. I've never heard of Anonymous Pro, so I imagine that most distros aren't shipping it by default, right?

IPython member

The fallback is still Monospace. This is the 'preferred' default. I can just make it Monospace, too, so there's no choice to be made.

Ah, OK. Your call then.

IPython member

I changed it back to just Monospace. That way it's only Windows that has two defaults, which matches the platform - Consolas is the logical default, but users on XP without VS might not have it. The defaults on the other two should always exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment