display any output from this session in terminal console #5253

Merged
merged 1 commit into from Mar 7, 2014

2 participants

@minrk
IPython member

rather than filtering based on the most recent msg_id.

avoids excluding async output displayed after status=idle

closes #5251

@minrk minrk display any output from this session in terminal console
rather than filtering based on the most recent msg_id.

avoids excluding async output displayed after status=idle

closes #5251
709fe10
@ellisonbg
IPython member

I think this looks fine, but we should wait to get feedback from the Julia folks.

@minrk
IPython member

An alternative we could add in the future is a threaded approach, where async output would really behave the same in the terminal (messing with the prompt and everything).

@minrk minrk added this to the 2.0 milestone Mar 7, 2014
@takluyver takluyver commented on the diff Mar 7, 2014
IPython/terminal/console/interactiveshell.py
@@ -222,26 +223,22 @@ def handle_execute_reply(self, msg_id, timeout=None):
self.execution_count = int(content["execution_count"] + 1)
- def handle_iopub(self, msg_id):
- """ Method to process subscribe channel's messages
+ def handle_iopub(self, msg_id=''):
@takluyver
IPython member
takluyver added a line comment Mar 7, 2014

Is the msg_id parameter still used at all. Do we want to remove/deprecate it?

@minrk
IPython member
minrk added a line comment Mar 7, 2014

I don't think it is right now, but I can imagine it being useful. I'll leave it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@minrk minrk merged commit 9338c65 into ipython:master Mar 7, 2014

1 check passed

Details default The Travis CI build passed
@minrk minrk deleted the minrk:console-async branch Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment