ipython notebook widgets examples - update path to widgets js files #5274

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
@epifanio
Contributor

epifanio commented Mar 5, 2014

No description provided.

@@ -78,7 +78,7 @@
"input": [
"%%javascript\n",
"\n",
- "require([\"notebook/js/widgets/widget\"], function(WidgetManager){\n",
+ "require([\"widgets/js/widget\"], function(WidgetManager){\n",
"\n",
" var FilePickerView = IPython.WidgetView.extend({\n",
" render: function(){\n",

This comment has been minimized.

@minrk

minrk Mar 5, 2014

Member

There's another one here on L133

@minrk

minrk Mar 5, 2014

Member

There's another one here on L133

This comment has been minimized.

@epifanio

epifanio Mar 5, 2014

Contributor

Thanks Min!

@epifanio

epifanio Mar 5, 2014

Contributor

Thanks Min!

This comment has been minimized.

@epifanio

epifanio Mar 5, 2014

Contributor

Now should be ok

@epifanio

epifanio Mar 5, 2014

Contributor

Now should be ok

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Mar 5, 2014

Member

I still see a few more cases in Part 6:

examples/widgets/Part 6 - Custom Widget.ipynb
123:      "All IPython widget code depends on `notebook/js/widgets/widget.js`,\n",
134:      "require([\"notebook/js/widgets/widget\"], function(WidgetManager){\n",
177:      "require([\"notebook/js/widgets/widget\"], function(WidgetManager){\n",
449:      "require([\"notebook/js/widgets/widget\"], function(WidgetManager){\n",
Member

minrk commented Mar 5, 2014

I still see a few more cases in Part 6:

examples/widgets/Part 6 - Custom Widget.ipynb
123:      "All IPython widget code depends on `notebook/js/widgets/widget.js`,\n",
134:      "require([\"notebook/js/widgets/widget\"], function(WidgetManager){\n",
177:      "require([\"notebook/js/widgets/widget\"], function(WidgetManager){\n",
449:      "require([\"notebook/js/widgets/widget\"], function(WidgetManager){\n",
@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Mar 7, 2014

Member

@epifanio could you fix the few remaining cases in Part 6?

Member

minrk commented Mar 7, 2014

@epifanio could you fix the few remaining cases in Part 6?

@ellisonbg

This comment has been minimized.

Show comment
Hide comment
@ellisonbg

ellisonbg Mar 7, 2014

Member

I have finished this up in #5289, closing.

Member

ellisonbg commented Mar 7, 2014

I have finished this up in #5289, closing.

@ellisonbg ellisonbg closed this Mar 7, 2014

jdfreder added a commit that referenced this pull request Mar 7, 2014

Merge pull request #5289 from ellisonbg/widget-path
Finishing up #5274 (widget paths fixes)
@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Apr 13, 2014

Member

Widgets aren't stored in the notebook file, so they won't work on nbviewer at all.

Member

minrk commented Apr 13, 2014

Widgets aren't stored in the notebook file, so they won't work on nbviewer at all.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #5289 from ellisonbg/widget-path
Finishing up #5274 (widget paths fixes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment