Skip to content

ipython notebook widgets examples - update path to widgets js files #5274

Closed
wants to merge 3 commits into from

4 participants

@epifanio
epifanio commented Mar 5, 2014

No description provided.

@minrk minrk commented on the diff Mar 5, 2014
examples/widgets/File Upload Widget.ipynb
@@ -78,7 +78,7 @@
"input": [
"%%javascript\n",
"\n",
- "require([\"notebook/js/widgets/widget\"], function(WidgetManager){\n",
+ "require([\"widgets/js/widget\"], function(WidgetManager){\n",
"\n",
" var FilePickerView = IPython.WidgetView.extend({\n",
" render: function(){\n",
@minrk
IPython member
minrk added a note Mar 5, 2014

There's another one here on L133

@epifanio
epifanio added a note Mar 5, 2014

Thanks Min!

@epifanio
epifanio added a note Mar 5, 2014

Now should be ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@minrk
IPython member
minrk commented Mar 5, 2014

I still see a few more cases in Part 6:

examples/widgets/Part 6 - Custom Widget.ipynb
123:      "All IPython widget code depends on `notebook/js/widgets/widget.js`,\n",
134:      "require([\"notebook/js/widgets/widget\"], function(WidgetManager){\n",
177:      "require([\"notebook/js/widgets/widget\"], function(WidgetManager){\n",
449:      "require([\"notebook/js/widgets/widget\"], function(WidgetManager){\n",
@minrk
IPython member
minrk commented Mar 7, 2014

@epifanio could you fix the few remaining cases in Part 6?

@ellisonbg
IPython member

I have finished this up in #5289, closing.

@ellisonbg ellisonbg closed this Mar 7, 2014
@minrk
IPython member
minrk commented Apr 13, 2014

Widgets aren't stored in the notebook file, so they won't work on nbviewer at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.