Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Zmq unicode #532

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

takluyver commented Jun 20, 2011

We can't have unicode input in the Qt console, because we encode it on the receiving end.

Owner

takluyver commented Jun 20, 2011

This seems to pass all tests apart from parallel, and parallel tests are failing in newapp on my machine anyway.

Owner

minrk commented Jun 20, 2011

This was definitely necessary in the parallel code when I wrote it, but it doesn't appear to be anymore. This does break a few tests, but I can fix them easily enough. I'll go ahead and merge with those fixes.

I should note that unicode execution did work just fine for me in newapp on all my machines prior to this change, as far as I could tell.

It would help if you would report test failures so I know they are failing :) I did see a new error introduces by the recent docstring pass, but other than that (which has since been fixed), I have all parallel tests passing on Linux, Windows, and OSX in newapp.

@minrk minrk closed this in 6136f0e Jun 20, 2011

Owner

takluyver commented Jun 20, 2011

OK, tests are passing on this machine. Probably a stale environment issue.

Owner

takluyver commented Jun 20, 2011

Hmmm, but I do still get several repeats of these, even in a clean environment:

[Application] type mismatch: submitted: datetime text != timestamp
[Application] Table _ exists and doesn't match db format, trying __1

Looks like there's 10 rounds of that. The tests in question still pass, but it's noticeable in the output.

Owner

minrk commented Jun 20, 2011

I think that means it's reusing a temp dir, and finding a previous tasks.db file. Check for a tasks.db somewhere in /tmp, and see if removing it solves the problem.

This should only be a transient issue for simultaneous users of newapp and master until newapp is merged. I could also ensure that the tests always use a new db file, preventing this warning.

Owner

takluyver commented Jun 20, 2011

Yes, that sorts it. Thanks!

@jenshnielsen jenshnielsen pushed a commit to jenshnielsen/ipython that referenced this pull request Jun 21, 2011

@minrk minrk move rekey to jsonutil from parallel.util
also make rekey accept basestring, not just str.

closes gh-532
fdbd582

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

@minrk minrk move rekey to jsonutil from parallel.util
also make rekey accept basestring, not just str.

closes gh-532
cc9965e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment