I617 #618

Merged
merged 3 commits into from Jul 22, 2011

2 participants

@takluyver
IPython member

Don't try to load readline when using the ZMQ shell. (Fixes #617)

Also, when using %history -g pattern, always show the numbers, because it's not much use if we don't.

@fperez fperez commented on an outdated diff Jul 22, 2011
IPython/zmq/zmqshell.py
@@ -80,6 +80,8 @@ class ZMQInteractiveShell(InteractiveShell):
displayhook_class = Type(ZMQShellDisplayHook)
display_pub_class = Type(ZMQDisplayPublisher)
+ readline_use = CBool(False)
@fperez
IPython member
fperez added a line comment Jul 22, 2011

Add a short comment explaining that this is overriding a parent traitlet b/c in the zmq kernel there's no point in having readline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@fperez
IPython member

After discussion and review on irc, we'll go with this too right away (modulo the small comments above)

@takluyver takluyver merged commit 28202e8 into ipython:master Jul 22, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment