Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use HTTPS getting mathjax from CDN #6249

Merged
merged 1 commit into from Jul 31, 2014

Conversation

@minrk
Copy link
Member

@minrk minrk commented Jul 31, 2014

Is there any reason not to do this now?

closes #6246

@minrk minrk added this to the 2.2 milestone Jul 31, 2014
@rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Jul 31, 2014

Definitely should be done, and should be backported to the 0.13.x, 1.x, and 2.x series to make it simpler for all the distros (they ended up patching the old versions).

takluyver added a commit that referenced this pull request Jul 31, 2014
always use HTTPS getting mathjax from CDN
@takluyver takluyver merged commit cf793eb into ipython:master Jul 31, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@Carreau
Copy link
Member

@Carreau Carreau commented Jul 31, 2014

As long as it does not confort user in thinking over http is secure.. even on localhost.

@rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Jul 31, 2014

This won't be transparent to the user, just mitigate external resources from having an attack point against their local box.

takluyver added a commit that referenced this pull request Aug 1, 2014
Is there any reason not to do this now?

closes #6246
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
always use HTTPS getting mathjax from CDN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.