always use HTTPS getting mathjax from CDN #6249

Merged
merged 1 commit into from Jul 31, 2014

Projects

None yet

4 participants

@minrk
Member
minrk commented Jul 31, 2014

Is there any reason not to do this now?

closes #6246

@minrk minrk added this to the 2.2 milestone Jul 31, 2014
@rgbkrk
Member
rgbkrk commented Jul 31, 2014

Definitely should be done, and should be backported to the 0.13.x, 1.x, and 2.x series to make it simpler for all the distros (they ended up patching the old versions).

@takluyver takluyver merged commit cf793eb into ipython:master Jul 31, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@Carreau
Member
Carreau commented Jul 31, 2014

As long as it does not confort user in thinking over http is secure.. even on localhost.

@rgbkrk
Member
rgbkrk commented Jul 31, 2014

This won't be transparent to the user, just mitigate external resources from having an attack point against their local box.

@takluyver takluyver added a commit that referenced this pull request Aug 1, 2014
@takluyver takluyver Backport PR #6249: always use HTTPS getting mathjax from CDN
Is there any reason not to do this now?

closes #6246
f58dabb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment