Generate package list automatically in find_packages #646

Merged
merged 1 commit into from Aug 1, 2011

Projects

None yet

2 participants

@minrk
Member
minrk commented Jul 30, 2011

Previously, the package list was manually specified, which meant that it became out of date any time a package was added, and IPython would become uninstallable. This would not be noticed for some time by developers, who always use setupegg.py --develop or symlinks.

This update immediately revealed that IPython.zmq.tests and IPython.extensions.tests were never included in 0.11. Other than that, there is no difference in the package list.

Wait for after 0.11, in case of unforeseen side effects.

@minrk
Member
minrk commented Aug 1, 2011

@fperez is there any reason that we should not do it this way? The only one I see is that you can change what's installed by creating new files inside the IPython dir, but this doesn't strike me as anything but an improvement.

@fperez
Member
fperez commented Aug 1, 2011

Nope, that's certainly the right way to do it. Merge away!

@minrk minrk Generate package list automatically in find_packages
Previously, the package list was manually specified, which meant that
it became out of date any time a package was added, and IPython would
become uninstallable. This would not be noticed for some time by
developers, who always use `setupegg.py --develop` or symlinks.

This update immediately revealed that IPython.zmq.tests and IPython.extensions.tests were never included in 0.11.  Other than that, there is no difference in the package list.
1eea56b
@minrk minrk merged commit 1eea56b into ipython:master Aug 1, 2011
@jasongrout jasongrout added a commit to jasongrout/ipython that referenced this pull request Feb 16, 2015
@jasongrout jasongrout Extract session buffers as memoryviews
A bug in pyzmq forces us to have a workaround, which can be deleted when the pyzmq dependency is upgraded to fix pyzmq issue #646.

Thanks to @minrk for helping work on the code and also for the bugfix in pyzmq.
d4b39a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment