parallel tests & extra readline escapes #666

Merged
merged 2 commits into from Aug 16, 2011

Conversation

Projects
None yet
2 participants
@minrk
Member

minrk commented Aug 3, 2011

See #662

This adds some extra waits, etc. to a few parallel tests, to make them less likely to fail, which they have done on rare occasion. It's difficult to be conclusive, given the multiprocessing/network nature of the tests.

It has also been revealed that when building python-readline for OSX 10.7 python-2.7, import readline prints the escape 'ESC[?1034h' to stdout (not sys.stdout, because it doesn't appear to be redirected, the hardwired process stdout). Since I've seen reference to this behavior of readline even outside Python (http://www.google.com/search?q=readline+1034h), I added handling to ignore it in the test suite, so IPython.core.tests.test_run once again passes all tests on system Python on OSX 10.7.

minrk added some commits Aug 2, 2011

strip leading 'ESC[?1034h' in tests caused by `import readline`
`import readline` causes 'ESC[?1034h' to be the first output sometimes,
so strip that off the front of the first line if it is found.

This has been reported to RedHat in 2007, but appears to only apply to
OSX 10.7 at the moment.

closes gh-662

fperez added a commit that referenced this pull request Aug 16, 2011

Merge pull request #666 from minrk/tests
Make parallel tests more robust via small delays.

Also, ignore spurious readline escapes that are sometimes sent to stdout and can confuse the test suite.

@fperez fperez merged commit 6d90a9e into ipython:master Aug 16, 2011

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #666 from minrk/tests
Make parallel tests more robust via small delays.

Also, ignore spurious readline escapes that are sometimes sent to stdout and can confuse the test suite.

@ghost ghost referenced this pull request Jul 9, 2015

Closed

Notebook CSS table #8581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment