Fix columnize bug, where tab completion with very long filenames would crash Qt console #696

Merged
merged 3 commits into from Aug 17, 2011

Projects

None yet

1 participant

@fperez
IPython member

Reported on list: http://mail.scipy.org/pipermail/ipython-user/2011-August/008184.html

Thanks to Mani Chandra for the report and Julian for the script to reproduce the bug.

fperez added some commits Aug 13, 2011
@fperez fperez Move columnization code out of GUI code so we can test it better. b46acf0
@fperez fperez Add failing test: columnize called with very long entries.
Bug reported on-list.
371bb8f
@fperez fperez Fix bug where tab-completion with very long filenames would crash the…
… qt console.

Any time tab completion was activated with a filename in the path
longer than the width of the window, the console would crash.
d4d04ba
@fperez
IPython member

Reviewed in detail on IRC channel, @minrk signs off on it so I'm merging it now.

@fperez fperez merged commit aa7247e into ipython:master Aug 17, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment