Fix columnize bug, where tab completion with very long filenames would crash Qt console #696

Merged
merged 3 commits into from Aug 17, 2011

Conversation

Projects
None yet
1 participant
@fperez
Member

fperez commented Aug 13, 2011

Reported on list: http://mail.scipy.org/pipermail/ipython-user/2011-August/008184.html

Thanks to Mani Chandra for the report and Julian for the script to reproduce the bug.

fperez added some commits Aug 13, 2011

Fix bug where tab-completion with very long filenames would crash the…
… qt console.

Any time tab completion was activated with a filename in the path
longer than the width of the window, the console would crash.
@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Aug 17, 2011

Member

Reviewed in detail on IRC channel, @minrk signs off on it so I'm merging it now.

Member

fperez commented Aug 17, 2011

Reviewed in detail on IRC channel, @minrk signs off on it so I'm merging it now.

fperez added a commit that referenced this pull request Aug 17, 2011

Merge pull request #696 from fperez/fix_columnize
Fix columnize bug, where tab completion with very long filenames would crash Qt console.

Thanks to Mani Chandra for reporting on list and Julian Taylor for the script to reproduce the crash.

@fperez fperez merged commit aa7247e into ipython:master Aug 17, 2011

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #696 from fperez/fix_columnize
Fix columnize bug, where tab completion with very long filenames would crash Qt console.

Thanks to Mani Chandra for reporting on list and Julian Taylor for the script to reproduce the crash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment